Skip to content

fix: don't compute bondDrinks for every item#1654

Open
midgleyc wants to merge 4 commits intoloathers:mainfrom
midgleyc:lta
Open

fix: don't compute bondDrinks for every item#1654
midgleyc wants to merge 4 commits intoloathers:mainfrom
midgleyc:lta

Conversation

@midgleyc
Copy link
Member

@midgleyc midgleyc commented Jun 4, 2025

Description

License to Adventure consumption code is currently really slow. Cache bondDrinks.

Get more yams, and get deliveries in hardcore (softcore can just pull drinks).

How Has This Been Tested?

Drunk a single drink and seemed okay.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have based my pull request against the main branch or have a good reason not to.
  • I have updated the GitHub wiki path or IOTM support pages, as appropriate.

@midgleyc midgleyc requested a review from Rinn June 5, 2025 08:16
@midgleyc
Copy link
Member Author

midgleyc commented Jun 5, 2025

It worked for my first three drinks of the day and now claims it can't find anything, but ash import autoscend; bondDrinks still seems to work as expected. Confusing.

@midgleyc midgleyc changed the title fix: don't compute bondDrinks for every item fix: don't compute bondDrinks for every item, spies can eat sausages Jun 5, 2025
@midgleyc midgleyc changed the title fix: don't compute bondDrinks for every item, spies can eat sausages fix: don't compute bondDrinks for every item Sep 14, 2025
@midgleyc
Copy link
Member Author

Ran again for another run and it went fine that time. Mysterious!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant