Expose a withMacro function that lets you carry out some arbitrary action with the given macro#834
Open
Expose a withMacro function that lets you carry out some arbitrary action with the given macro#834
Conversation
spaghetti-squash
requested changes
Dec 13, 2025
| * Create and set a CCS file from a given Macro | ||
| * @param macro Macro to set as CSS | ||
| */ | ||
| export function makeCcs<M extends StrictMacro>(macro: M) { |
Contributor
There was a problem hiding this comment.
Suggested change
| export function makeCcs<M extends StrictMacro>(macro: M) { | |
| export function makeCcs<M extends Macro>(macro: M) { |
While the garbo version extends the hotter and cooler StrictMacro class, which we use exclusively, this should probably use the OG
Comment on lines
+927
to
+932
| if (macroOrAction instanceof Macro || actionOrTryAuto === true) { | ||
| macro.setAutoAttack(); | ||
| } | ||
|
|
||
| // Make a CCS of the macro or, if we have two, the second macro. | ||
| makeCcs(macroOrAction instanceof Macro ? macroOrAction : macro); |
Contributor
There was a problem hiding this comment.
The overloads bamboozled me a little bit but I trust TS that this is correct
Co-authored-by: neil <78829653+spaghetti-squash@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.