Release v1.0.1

.github/workflows/ci.yml

@@ -13,8 +13,6 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-      - name: Build
-        run: make all
       - name: Run tests
         run: make test
       - name: Create Release

Makefile

@@ -1,17 +1,23 @@
-CC=cc
-CFLAGS=-O2 -pipe -Wshadow -Werror -I./include
+CC ?= cc
+CFLAGS ?= -O2 -pipe -Wall -Wextra -Wshadow -Werror -std=c99 -I./include
+
+SRC = src/main.c src/validation_utils.c
+TEST_SRC = tests/unit/test_validation.c src/validation_utils.c
+TEST_BIN = tests/unit/test_validation
 
 all: checkrc
 
-checkrc:
-	$(CC) $(CFLAGS) src/main.c src/validation_utils.c -o checkrc
+checkrc: $(SRC)
+	$(CC) $(CFLAGS) $^ -o $@
+
+$(TEST_BIN): $(TEST_SRC)
+	$(CC) $(CFLAGS) $^ -o $@
 
-test: checkrc
-	$(CC) $(CFLAGS) -o tests/unit/test_validation tests/unit/test_validation.c src/validation_utils.c
-	./tests/unit/test_validation
+test: checkrc $(TEST_BIN)
+	./$(TEST_BIN)
 	sh tests/integration/test_checkrc.sh
 
 clean:
-	rm -f checkrc tests/unit/test_validation
+	rm -f checkrc $(TEST_BIN)
 
 .PHONY: all test clean

README.md

@@ -76,4 +76,4 @@ This command compiles and builds the entire project using FreeBSD `make`.
 
 Don't worry if you're new to this or even if you’re facing some issues along the way; we're here to help! If you have any questions or need a bit of guidance, feel free to reach out by creating an issue in the repository or dropping us a message. Let’s make `checkrc` even better, together!
 
-Thanks for being a part of our community!
+Thanks for being a part of our community!

src/validation_utils.c

@@ -1,6 +1,7 @@
 #include <ctype.h>
 #include <stdio.h>
 #include <string.h>
+#include <strings.h>
 
 #include "validation_utils.h"
 #include <arpa/inet.h>

tests/integration/test_checkrc.sh

@@ -17,4 +17,4 @@ if [ $? -eq 0 ]; then
 fi
 
 echo "All integration tests passed successfully"
-exit 0 
+exit 0

tests/integration/test_files/invalid_rc.conf

@@ -4,4 +4,4 @@ defaultrouter="bad host!"  # Invalid hostname
 ipv6_defaultrouter="2001:db8::g"  # Invalid IPv6
 sshd_enable="enabled"  # Invalid boolean
 ntpd_enable="1"  # Invalid boolean
-rcshutdown_timeout="fast"  # Invalid integer 
+rcshutdown_timeout="fast"  # Invalid integer

tests/integration/test_files/valid_rc.conf

@@ -4,4 +4,4 @@ defaultrouter="router.example.com"
 ipv6_defaultrouter="fe80::1%em0"
 sshd_enable="YES"
 ntpd_enable="NO"
-rcshutdown_timeout="30" 
+rcshutdown_timeout="30"

tests/unit/minunit.h

@@ -35,4 +35,4 @@ static int tests_failed = 0;
      printf("Tests failed: %d\n", tests_failed), \
      tests_failed ? EXIT_FAILURE : EXIT_SUCCESS)
 
-#endif 
+#endif 

tests/unit/test_validation.c

@@ -89,6 +89,7 @@ MU_TEST_SUITE(test_suite) {
     MU_RUN_TEST(test_boolean_validation);
     MU_RUN_TEST(test_integer_validation);
     MU_RUN_TEST(test_string_validation);
+    return NULL;
 }
 
 int main() {