Skip to content

[P2] Set the public Spotify client authentication method in the configuration example #64

Closed

Description

@michielbdejong

Recorded during review of main at a1eb305ccfa2f3fc8ddede4875765cf1b099bd2b. This issue records a finding only; no implementation changes were made or requested.

Finding

The example and Spotify setup text say no client secret is needed, but omit OAUTH_SPOTIFY_CLIENT_AUTH_METHOD=none. Generic provider registration defaults to client_secret_post, which requires a secret unless the method is explicitly set to none (or fails earlier if incompatible with metadata). The later generic migration note does not make the platform-specific example complete.

Evidence

Desired outcome

Include the required public-client method setting in the Spotify example and setup instructions without introducing provider-name special cases in code.

Activity

  1. michielbdejong commented on Sep 16, 2026

    @michielbdejong
    ContributorAuthor

    Fixed in #73 — added OAUTH_SPOTIFY_CLIENT_AUTH_METHOD=none to .env.example and the README's Spotify section, so the example is self-consistent with its "no client secret needed" claim. (Verified against the live default catalog pin that Spotify's declared token_endpoint_auth_methods_supported metadata already causes the proxy to auto-select none, but making it explicit guards against that upstream metadata changing and matches this issue's desired outcome.)


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions