[P2] Remove hardcoded Atomic Data Hub wording from generic connection consent #66

Recorded during review of main at a1eb305ccfa2f3fc8ddede4875765cf1b099bd2b. This issue records a finding only; no implementation changes were made or requested.

Finding

Production consent UI hardcodes “Target Atomic Data Hub” and “sync ... with your Atomic Data Hub.” This is client-product coupling despite generic platform routing and return origins.

The review’s platform-specificity audit found no production branches selecting behavior by Google Calendar, GitHub, Spotify, Discord, Moneybird, or Todoist name. OAuth behavior comes from catalog metadata and generic credential-variable conventions. Tenant login itself uses configurable OIDC endpoints.

Other named-platform references are platform-specific tests, documentation and environment examples; a GitHub-motivated but universally applied User-Agent; and the default GitHub-hosted LocalThought catalog. These are inventory/context, not evidence of platform-name branching or requests to remove legitimate regression fixtures. The README also retains an obsolete “built-in providers” description despite catalog-driven configuration.

Evidence

• src/templates.rs:55
• src/main.rs:47
• src/config.rs:57
• src/providers.rs:20
• README.md:86

Desired outcome

Use generic destination/application wording or explicitly configured client branding in consent. Keep platform behavior catalog-driven and document the remaining intentional deployment/test coupling accurately.