Repository navigation
Add AGENTS.md: generic proxy / overlay separation of concerns - #71
Merged
Merged
Conversation
PR #46 added an ignored test in src/catalog.rs asserting Moneybird- specific facts (collection counts, scope lists, throttling numbers) directly in this repo. It was reverted in PR #70 because that content already belongs in, and is already published and validated by, localthought/overlays via OpenAPI/Overlay documents. Document the boundary so future contributions land in the right repo. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The prior wording read as banning any platform-specific assertion in this repo, which would have also outlawed the existing pinned-fixture tests in src/identity_catalog_tests.rs and src/catalog.rs. The actual boundary is about production src/ code never branching on platform identity or hand-authoring platform data; a test asserting facts about a pinned localthought/overlays fixture is the right way to prove the generic composition pipeline works for real inputs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
michielbdejong
deleted the
claude/integration-proxy-separation-b117eb
branch
September 15, 2026 13:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
localthought/overlays(platform-specific OpenAPI/Overlay documents), prompted by the revert-then-close cycle on Publish full Moneybird records and Calendar schema metadata #46/Revert "Publish full Moneybird records and Calendar schema metadata" #70.src/code must never branch on or hand-author platform data, while pinned-fixture tests asserting composed output (the existing pattern insrc/identity_catalog_tests.rsandsrc/catalog.rs) are fine and encouraged.Test plan
🤖 Generated with Claude Code