Skip to content

Bump DEFAULT_CATALOG_PATH: google-calendar migrated to the full calendar/v3 OAD - #76

Open
michielbdejong wants to merge 1 commit into
mainfrom
bump-catalog-pin-gcal-oad-migration
Open

michielbdejong wants to merge 1 commit into
mainfrom
bump-catalog-pin-gcal-oad-migration

Conversation

@michielbdejong

Copy link
Copy Markdown
Contributor

Summary

Part of localthought/atomic-plugins#5 (Phase 1: close the calendar write-back gap). The platform-specific fix landed in localthought/overlays as overlays#168, per AGENTS.md's "Making a platform-specific fix" workflow — this is step 3, the one-line, platform-agnostic follow-up.

ontola/openapi-directory removed the hand-written, read-only google-calendar/v3 subset document the previous pin's composed catalog was built from, replacing it with a regenerated, full calendar/v3 document converted from Google's own Discovery document (their reasoning: "the generated calendar/v3 document is the same API, complete"). The previous pin (this repo's own #75) keeps resolving by SHA, so nothing is broken in production today, but it points at a path that no longer exists on either openapi-directory fork's default branch — worth moving off before that stops being true.

  • Bumps DEFAULT_CATALOG_PATH in src/config.rs to the new pin.
  • Updates the matching pin in identity_catalog_tests.rs's published_catalog_loads_trusted_google_and_github_identity_operations.
  • Regenerates the checked-in tests/identity-catalog/google-calendar-composed.yaml and sources.json fixtures from the new pin. The fixture grows substantially (the full base document vs. the old ~250-line subset) — that's the base-document swap, not new platform behavior.

No src/ runtime behavior changes.

Note on scope: the linked overlays PR deliberately branches off the currently-deployed catalog pin rather than overlays' main tip, because main has since merged an unrelated clockify catalog entry with no oauthSecurityScheme selection that fails Catalog::oauth_provider for every platform once composed — confirmed by running this repo's own default_catalog_pin_selects_google_offline_and_spotify_pkce_profiles test against a main-based composition (it panicked on clockify, not on anything google-calendar-related). That's a real, separately-scoped bug worth its own fix; out of scope here.

Deployment: merging this changes the compiled-in default only; the running service also needs a restart before it picks up the new pin. Not done as part of this PR.

Test plan

  • cargo test --bin auth-proxy — 100 passed, 22 ignored (network/DB-gated), 0 failed.
  • cargo test --bin auth-proxy -- --ignored default_catalog_pin_selects_google_offline_and_spotify_pkce_profiles pinned_catalog_supplies_oauth_and_canonical_pagination_paths published_catalog_loads_trusted_google_and_github_identity_operations — all 3 pass against the new live pin.
  • cargo fmt --check — clean.
  • Live PATCH against a real Google Calendar event — not done here (same as Bump DEFAULT_CATALOG_PATH: google-calendar events now support PATCH #75); needs a deployed instance and a real connected account.

🤖 Generated with Claude Code

…dar/v3 OAD

Part of atomic-plugins#5 (Phase 1: close the calendar write-back gap).
The platform-specific fix landed in localthought/overlays as
localthought/overlays#168, per AGENTS.md's "Making a platform-specific
fix" workflow — this is step 3, the one-line, platform-agnostic
follow-up.

ontola/openapi-directory removed the hand-written, read-only
google-calendar/v3 subset document the previous pin's composed catalog
was built from, replacing it with a regenerated, full calendar/v3
document converted from Google's own Discovery document. The previous
pin (this repo's own PR #75) keeps resolving by SHA, so nothing is
broken today, but it points at a path that no longer exists on either
openapi-directory fork's default branch.

- Bumps `DEFAULT_CATALOG_PATH` in `src/config.rs` to the new pin.
- Updates the matching pin in `identity_catalog_tests.rs`'s
  `published_catalog_loads_trusted_google_and_github_identity_operations`.
- Regenerates the checked-in `tests/identity-catalog/google-calendar-composed.yaml`
  and `sources.json` fixtures from the new pin (the full base document is
  much larger than the old subset, hence the fixture's size).

No `src/` runtime behavior changes.

## Test plan

- `cargo test --bin auth-proxy` — 100 passed, 22 ignored, 0 failed.
- `cargo test --bin auth-proxy -- --ignored default_catalog_pin_selects_google_offline_and_spotify_pkce_profiles pinned_catalog_supplies_oauth_and_canonical_pagination_paths published_catalog_loads_trusted_google_and_github_identity_operations` — all 3 pass against the new live pin.
- `cargo fmt --check` — clean.
- Live PATCH against a real Google Calendar event — not done here; needs a deployed instance and a real connected account.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant