Skip to content

Fetch the OAD documents/overlays from their new homes instead of vendoring them - #26

Merged
michielbdejong merged 1 commit into
mainfrom
relocate-oad-to-openapi-directory
Sep 8, 2026
Merged

michielbdejong merged 1 commit into
mainfrom
relocate-oad-to-openapi-directory

Conversation

@michielbdejong

Copy link
Copy Markdown
Contributor

Summary

Validation

  • Fetched bytes are byte-identical to what was removed (diffed against the pre-move commit).
  • cargo fmt --check, cargo test (51 passed), cargo clippy --all-targets -- -D warnings, and both wasm32 checks (cargo build/clippy --target wasm32-unknown-unknown --lib) all pass — none of them touch spec/.
  • Ran the actual built binary zero-config (PUBLIC_URL=... cargo run, no other config) against freshly scripts/fetch-oad.sh-fetched files: it resolved spec/github/github-issues.openapi.yaml, applied all three overlays, derived 19 ontology terms, and made a real request against api.github.com — the README's stand-alone path works end to end.

🤖 Generated with Claude Code

https://claude.ai/code/session_012bmJGaUn2iAazsUGqaL98N


Generated by Claude Code

…oring them

github-issues.openapi.yaml, google-calendar.openapi.yaml and their six
overlays moved to localthought/openapi-directory (PR #1) and
localthought/overlays (PR #145), superseding the file removals proposed
in #23/#24. This adds scripts/fetch-oad.sh, which pulls them back into
the exact same spec/<platform>/ paths GITHUB_DEFAULTS/GOOGLE_CALENDAR_DEFAULTS
already pointed at (pinned by commit), so config.rs needs no path changes.
spec/ is now gitignored rather than committed.

Verified: fetched bytes are byte-identical to what was removed; cargo
test/clippy/fmt and both wasm32 checks pass without running the script
(nothing in the suite touches spec/); the built binary, run zero-config
against the fetched files, resolves the document, applies all three
overlays, derives the ontology and makes a real request to the GitHub API
— the README's stand-alone path still works end to end.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012bmJGaUn2iAazsUGqaL98N
@michielbdejong
michielbdejong merged commit a299b20 into main Sep 8, 2026
1 check passed
michielbdejong pushed a commit to ontola/atomic-server that referenced this pull request Sep 8, 2026
…grations

Reflector's OAD documents and overlays no longer live in its own repo
(moved to localthought/openapi-directory and localthought/overlays,
fetched by Reflector's scripts/fetch-oad.sh into spec/ — see
localthought/reflector-rs#26), so the catalog can no longer infer which
integrations exist by scanning spec/ for folders. discover() now reads
the operator-set OAD_INTEGRATIONS env var (a comma-separated list of
spec/<id> ids) instead; load() itself is unchanged.

Bumps the pinned reflector-rs revision to a299b200 (main, after merging
#25 and #26) and updates the OAD import docs and CLI walkthrough to
match: REFLECTOR_ROOT now needs spec/ fetched via Reflector's own script,
and OAD_INTEGRATIONS set to opt integrations into the Sync page.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012bmJGaUn2iAazsUGqaL98N
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants