feat: attestation index=1 requires FULL variant (consensus-specs#4918)#10
Closed
lodekeeper wants to merge 1 commit intounstablefrom
Closed
feat: attestation index=1 requires FULL variant (consensus-specs#4918)#10lodekeeper wants to merge 1 commit intounstablefrom
lodekeeper wants to merge 1 commit intounstablefrom
Conversation
Attestation with index=1 (full node) now requires the FULL variant to exist in the proto-array. Throws UNKNOWN_PAYLOAD_STATUS if payload has not been seen.
|
@lodekeeper consider this done, will bring this to unstable separately, go ahead and close this PR |
Owner
Author
|
Closing as requested — will be picked up in the unstable integration PR. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Attestation with
index=1(full node) must require the FULL variant to exist, per ethereum/consensus-specs#4918.Changes
validate_on_attestation: if attesting for index=1, payload must be knownUNKNOWN_PAYLOAD_STATUSerror code toInvalidAttestationCodeSplit from alpha.3 upgrade PR #6.