feat: add isPendingValidator helper (consensus-specs#4897, #4916)#9
Closed
lodekeeper wants to merge 1 commit intounstablefrom
Closed
feat: add isPendingValidator helper (consensus-specs#4897, #4916)#9lodekeeper wants to merge 1 commit intounstablefrom
lodekeeper wants to merge 1 commit intounstablefrom
Conversation
…4916) - Add isPendingValidator() to check if a pubkey has a valid pending deposit - Update processDepositRequest builder routing to check !isPendingValidator() - Naive implementation without caching (TODO tracked for optimization)
|
@lodekeeper consider this done, will bring this to unstable separately, go ahead and close this PR |
Owner
Author
|
Closing per Nico's direction — will be brought to unstable separately. |
lodekeeper
added a commit
that referenced
this pull request
Apr 24, 2026
…hainSafe#9266) ## Summary Nightly Kurtosis sim on `unstable` has been failing since 2026-04-15 with: ``` at [github.com/ethpandaops/ethereum-package/src/zkboost/zkboost_launcher.star:272:17]: undefined: GpuConfig (did you mean get_config?) at [github.com/ethpandaops/ethereum-package/main.star:67:24]: <toplevel> ``` Ref: https://github.com/ChainSafe/lodestar/actions/runs/24865616925/job/72800866667 ## Root cause - `ethpandaops/ethereum-package#1353` (merged 2026-04-15) introduced `GpuConfig` in `src/zkboost/zkboost_launcher.star`. That predeclared global was added in [Kurtosis 1.18.1](https://github.com/kurtosis-tech/kurtosis/releases/tag/1.18.1). - Kurtosis's Starlark resolver checks predeclared names at module load time, and `main.star` imports `zkboost_launcher.star` unconditionally — so any Kurtosis < 1.18.1 hits this error even when zkboost is not enabled. - We pin `ethpandaops/kurtosis-assertoor-github-action@5932604b # v1`. At that sha the action installs via `apt.fury.io/kurtosis-tech`, which caps out at `1.15.2`. Even with `kurtosis_version: latest`, apt resolves to `1.15.2`. ## Fix Bump to `v1.0.1` (`f64942cb`), which switches the apt source to `sdk.kurtosis.com/kurtosis-cli-release-artifacts` ([action PR #9](ethpandaops/kurtosis-assertoor-github-action#9)). That repo has `1.18.1` available; `kurtosis_version: latest` then picks it up and the Starlark resolves. ## Test plan - [ ] Trigger the workflow manually on this PR's branch via `workflow_dispatch` and confirm the sim runs past Starlark evaluation. 🤖 Generated with AI assistance Co-authored-by: lodekeeper <lodekeeper@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add
isPendingValidator()helper per ethereum/consensus-specs#4897 and ethereum/consensus-specs#4916.Changes
isPendingValidator()instate-transition/src/util/gloas.tsprocessDepositRequestbuilder routing to check!isPendingValidator(...)Split from alpha.3 upgrade PR #6.