Skip to content

Fix #10: LofarStMan is incompatible with CMake FetchContent#11

Merged
aroffringa merged 3 commits into
mainfrom
fix-10
Mar 17, 2026
Merged

Fix #10: LofarStMan is incompatible with CMake FetchContent#11
aroffringa merged 3 commits into
mainfrom
fix-10

Conversation

@aroffringa
Copy link
Copy Markdown
Contributor

@aroffringa aroffringa commented Mar 17, 2026

AI told me this should be fixed this way. This fixes #10 .

@aroffringa aroffringa requested a review from gmloose March 17, 2026 12:40
@aroffringa aroffringa self-assigned this Mar 17, 2026
@Dantali0n
Copy link
Copy Markdown

AI is correct here, I did the same in #12 feel free to close 12 in favor or this or the other way around.

Below is an example of how to use this with Fetchcontent:

find_package(LofarStMan QUIET)

if(NOT LofarStMan_FOUND)
    set(ORIG_CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH})
    list(APPEND CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake")  #change for FindCasacore.cmake path
    FetchContent_Declare(
        LofarStMan
        GIT_REPOSITORY https://github.com/Dantali0n/LofarStMan.git
        GIT_TAG fix-fetchconten
    )
    FetchContent_MakeAvailable(LofarStMan)
    set(CMAKE_MODULE_PATH ${ORIG_CMAKE_MODULE_PATH})
endif()

Copy link
Copy Markdown

@gmloose gmloose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aroffringa aroffringa merged commit 8746db7 into main Mar 17, 2026
2 checks passed
@aroffringa aroffringa deleted the fix-10 branch March 17, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LofarStMan is incompatible with CMake FetchContent

3 participants