Skip to content

Remove dead code from ndimage_alg#279

Open
AlexKurek wants to merge 2 commits into
lofar-astron:masterfrom
AlexKurek:Remove-dead-code-from-ndimage_alg
Open

Remove dead code from ndimage_alg#279
AlexKurek wants to merge 2 commits into
lofar-astron:masterfrom
AlexKurek:Remove-dead-code-from-ndimage_alg

Conversation

@AlexKurek
Copy link
Copy Markdown
Contributor

This is a dead code, its not used or returned by the function.

@gmloose
Copy link
Copy Markdown
Collaborator

gmloose commented May 20, 2026

I wonder if it's dead code, or (worse) a missing assignment like:

            img.pyrank = pyrank

As in line 138.
@darafferty?

@darafferty
Copy link
Copy Markdown
Collaborator

Hmm, good question... I'm not sure why the code was left, but perhaps it happened when the option to use user-supplied source locations was added. Anyway, I think it's fine to remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants