Fix computing the number of unmasked pixels assigned to island#294
Open
AlexKurek wants to merge 1 commit into
Open
Fix computing the number of unmasked pixels assigned to island#294AlexKurek wants to merge 1 commit into
AlexKurek wants to merge 1 commit into
Conversation
…d in `Island` class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the constuctor there is
copy=FalseSo
if not copy:block will always be executed. Within this block:isl_mask = (labels[tuple(bbox)] == idx)so True means pixels within the island.
This mask is inverted below:
N.logical_not(isl_mask, isl_mask)Since the mask is inverted, currently this line:
pixels_in_isl = N.sum(~N.isnan(self.image[self.mask_active]))seems to count not-NaN pixels outside the island. To fix it:
pixels_in_isl = N.sum(~N.isnan(self.image[~self.mask_active]))Am I right? This produces chenges in I think every line in the .gaul file.