Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SABnzbd history reports
Failed/Aborted, but recovery recognized only lowercase raw status names and stopped polling before the error grace period expired. Recovery now consumes the adapter’s normalized failure flag, keeps grace polling active, and frees the stopped transfer’s capacity slot. Verified association, configured grace/disable policies, and deduplicated blocklist/replacement handling remain in force.Direct MAM search always requested all releases. Administrators can now enable Exclude VIP releases in MAM settings. This sends the documented
nVIPfilter, skips known VIP candidates before inspection, and rechecks fresh detail before fetching metadata or requesting a wedge. Exhausted selections explain the exclusion; a VIP result without a download reference explains the access check. The switch defaults off, preserves VIP/Elite access without expiry metadata, and does not infer entitlement or enable spending. It applies only to direct MAM; Prowlarr configuration remains separate. Save the setting and refresh existing searches.Current main already inspects every candidate once, so this does not increase an inspection budget. NOR-69/NOR-71 remain outside this PR pending their existing installation-specific search evidence.
Validation, run serially through
python3 scripts/check.py:git diff --checkpassed.Before-fix regressions reproduced missing SAB grace polling, outbound
searchType: all, and inspection of an excluded VIP candidate. Validation uses local HTTP fixtures and a disposable PostgreSQL database, not a live MAM account or SABnzbd installation. No live downloads or account purchases were made. Existing settings storage is reused; no migration is required.Fixes NOR-90, NOR-96.
Closes #57.
Closes #63.
PR review follow-up
The shared library-review browser check could fail when “Save and review next” displayed the completed-link status and the next catalog-search status together. The fixture now holds that next lookup pending, checks both messages separately, and waits for the lookup to finish before continuing. The ambiguous assertion failed under this controlled timing before the fix; no product behavior or timeout was changed.
The shared regression passed on #73, whose LibraryReview, AssetMatchForm, App and SelectMenu files are byte-identical to this branch. It also passed on #71 and #72 with their changed dropdown/onboarding code. Existing runtime validation above remains applicable; this follow-up changes only the browser test.