Open
Conversation
…nd trigger image build.
…hanc-github-action-is-not-triggering-builds-correctly 146 bug wrong path in orthanc GitHub action is not triggering builds correctly
Adds ignore rules for generated certificates to keep private keys and cert files out of version control.
Rename CI workflow files to reflect services and adjust trigger paths. This improves CI trigger accuracy on pull requests. Signed-off-by: R. Garcia-Dias <rafaelagd@gmail.com>
Adds each workflow's own YAML file to the watched paths so CI runs on configuration updates. Adjusts test workflows to reference the correct test configuration files. Removes unused comment and adds OIDC permissions for token issuance.
Adds a codecov.yml at the repo root that enables carryforward flags for all five sub-projects (flip-api, flip-ui, imaging-api, trust-api, data-access-api). This prevents Codecov from marking reports as incomplete when only a subset of workflows run due to path-filtered push triggers. Also fixes stale self-referencing workflow filenames in the push paths filter of test_flip_api.yml and test_flip_ui.yml. Closes #144 Signed-off-by: R. Garcia-Dias <rafaelagd@gmail.com>
Rename GitHub Actions workflow names to align with updated component naming conventions, improving clarity and consistency across the repository.
…ve unused FL_API_PORT variable, and adjust S3 paths for service directories
…e-reports Solves [Bug]: codecov incomplete reports #144
…dthedocs 145 bug fix images in readthedocs
Streamline README files across the repository by removing duplicate boilerplate and updating licensing headers. Reorganize sections for clarity, ensuring consistent documentation structure.
Removes obsolete secret entries to keep baseline tidy.
Add per-service CONTRIBUTING.md files for flip-api, flip-ui, and trust services, documenting setup, testing, linting, signing, and PR workflow. These guides complement the root CONTRIBUTING.md and streamline onboarding of contributors.
Adds *.crt pattern to ignore and creates the trust/certs directory for certificates.
All API entrypoints hard-coded 'fastapi dev --reload' regardless of environment, which enables file-watching and hot-reload in production. Branch on the ENV variable (defaulting to 'development'): - ENV=production or ENV=staging → fastapi run (no --reload) - otherwise → fastapi dev --reload (preserves local dev behaviour) Fixes #154
The trust services used a boolean PROD variable (0/1) to derive the
environment name, inconsistent with flip-api which uses a string ENV
variable (development/production).
Replace PROD with ENV=os.getenv("ENV", "development") across all three
trust config.py files to standardise environment detection.
The three trust services (imaging-api, data-access-api, trust-api) were missing an explicit ENV variable in their Docker Compose environment blocks. Without it the entrypoints defaulted to 'development' in every deployment. Set ENV=development in compose_trust.development.yml and ENV=production in compose_trust.production.yml for all three services.
When training was stopped, the 'Model Prepared' step incorrectly showed the stopped indicator (🚫) instead of staying completed (✅). This happened because STOPPED has a lower ordinal value than PREPARED in ModelStatusEnum, so the comparison 'statusValue >= PREPARED' evaluated to false. Since 'stopped' was also set to true, the AiSteps component rendered the stop icon. The fix ensures that terminal states (STOPPED, ERROR) do not regress prior completed steps: - 'Model Prepared' is always marked completed when stopped or errored (since training can only be stopped after preparation) - 'Training Started' shows the stopped/error indicator instead - 'Model Created' is always completed (unchanged) Fixes #29
…dation 4 feature fl port consolidation and fix FLARE client-server connection
…ep-indicators-29 fix: preserve completed step indicators when training is stopped
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…o-docs Add component-specific docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linked Issues
Fixes #
Checklist
Type of Change
make -C docs/ docs.Testing
I did the following tests to verify my changes:
make unit-test.make integration-test.Additional Notes