Conversation
…structor params Replaces 8 flat keyword arguments on PDFTableExtractor.__init__ with a single PDFExtractorOptions dataclass, bringing the constructor within pylint R0913/R0917 design limit. All callers (extraction_facade, analyze_pdf, tests) updated to use the new options= parameter. No behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Closes #109.
PDFTableExtractor.__init__had 11 parameters, exceeding pylint R0913/R0917 design limit. This PR groups the optional config arguments into aPDFExtractorOptionsdataclass, reducing the constructor to 3 parameters (columns,options,pdf_reader).Changes
extraction_params.py: addPDFExtractorOptionsdataclass with all 8 optional config fieldspdf_extractor.py: replace flat keyword args withoptions: PDFExtractorOptions | None = Noneextraction_facade.py: updateextract_tables_from_pdf()to construct and passPDFExtractorOptionscommands/analyze_pdf.py: update_validate_extraction()to usePDFExtractorOptionstest_pdf_extractor.py,test_page_skipping.py,test_document_type_enrichment.py,test_credit_card_detection.pyType
Testing
Checklist
Downstream impact
bankstatements_core(exported class, function, or exception)