Skip to content

test(authority): qualify Turn ownership with NoKV - #3820

Closed
wchwawa wants to merge 12 commits into
mainfrom
codex/authority-qualification-e2e
Closed

test(authority): qualify Turn ownership with NoKV#3820
wchwawa wants to merge 12 commits into
mainfrom
codex/authority-qualification-e2e

test(authority): require real peer worktree

3189df8
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Sep 1, 2026 in 3m 26s

Quality Gate failed

Failed conditions
3.4% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 310 in loopx/control_plane/turn_driver/authority_checkpoint.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Turn authority checkpoint journal is invalid" 4 times. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaBfJ6fer27B0i1l2FW3&open=AaBfJ6fer27B0i1l2FW3&pullRequest=3820

Check warning on line 71 in loopx/control_plane/turn_driver/authority_checkpoint.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use concise character class syntax '\d' instead of '[0-9]'. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaBfJ6ffr27B0i1l2FW9&open=AaBfJ6ffr27B0i1l2FW9&pullRequest=3820

Check warning on line 71 in loopx/control_plane/turn_driver/authority_checkpoint.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use concise character class syntax '\d' instead of '[0-9]'. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaBfJ6ffr27B0i1l2FW4&open=AaBfJ6ffr27B0i1l2FW4&pullRequest=3820

Check warning on line 24 in tests/test_nokv_authority_guard_provider_selection.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Split this composite assertion into separate assertions. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaBfJ6h-r27B0i1l2FXD&open=AaBfJ6h-r27B0i1l2FXD&pullRequest=3820

Check failure on line 386 in examples/nokv-shadow-provider/authority_guard.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 19 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaBfJ6iSr27B0i1l2FXI&open=AaBfJ6iSr27B0i1l2FXI&pullRequest=3820

Check warning on line 785 in tests/test_authority_turn_product_e2e.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the "monkeypatch" fixture for temporary modifications instead of manually modifying global state. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaBfJ6h1r27B0i1l2FXB&open=AaBfJ6h1r27B0i1l2FXB&pullRequest=3820

Check warning on line 753 in loopx/control_plane/turn_driver/authority_checkpoint.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Fix this condition that always evaluates to false. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaBfJ6ffr27B0i1l2FXA&open=AaBfJ6ffr27B0i1l2FXA&pullRequest=3820

Check failure on line 51 in examples/nokv-shadow-provider/authority_guard.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

LLMs running this code with faulty CLI arguments can escape file system restrictions. Refactor this code to validate the constructed path before accessing the file system. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaBfJ6iSr27B0i1l2FXJ&open=AaBfJ6iSr27B0i1l2FXJ&pullRequest=3820

Check warning on line 71 in loopx/control_plane/turn_driver/authority_checkpoint.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use concise character class syntax '\d' instead of '[0-9]'. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaBfJ6ffr27B0i1l2FW-&open=AaBfJ6ffr27B0i1l2FW-&pullRequest=3820

Check warning on line 1088 in loopx/control_plane/turn_driver/executor.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Function "_typed_settlement_stage" has 14 parameters, which is greater than the 13 authorized. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaBfJ6Qsr27B0i1l2FW2&open=AaBfJ6Qsr27B0i1l2FW2&pullRequest=3820

Check failure on line 263 in examples/nokv-shadow-provider/authority_turn_canary.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Catch a more specific exception or reraise the exception 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaBfJ6iIr27B0i1l2FXE&open=AaBfJ6iIr27B0i1l2FXE&pullRequest=3820

Check warning on line 71 in loopx/control_plane/turn_driver/authority_checkpoint.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use concise character class syntax '\d' instead of '[0-9]'. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaBfJ6ffr27B0i1l2FW8&open=AaBfJ6ffr27B0i1l2FW8&pullRequest=3820

Check warning on line 789 in tests/test_authority_turn_product_e2e.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the "monkeypatch" fixture for temporary modifications instead of manually modifying global state. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaBfJ6h1r27B0i1l2FXC&open=AaBfJ6h1r27B0i1l2FXC&pullRequest=3820

Check failure on line 211 in examples/nokv-shadow-provider/authority_guard.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "coordination authority head is missing" 3 times. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaBfJ6iSr27B0i1l2FXG&open=AaBfJ6iSr27B0i1l2FXG&pullRequest=3820

Check failure on line 344 in examples/nokv-shadow-provider/authority_turn_canary.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 28 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaBfJ6iIr27B0i1l2FXF&open=AaBfJ6iIr27B0i1l2FXF&pullRequest=3820

Check warning on line 71 in loopx/control_plane/turn_driver/authority_checkpoint.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use concise character class syntax '\d' instead of '[0-9]'. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaBfJ6ffr27B0i1l2FW5&open=AaBfJ6ffr27B0i1l2FW5&pullRequest=3820

Check warning on line 71 in loopx/control_plane/turn_driver/authority_checkpoint.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use concise character class syntax '\d' instead of '[0-9]'. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaBfJ6ffr27B0i1l2FW7&open=AaBfJ6ffr27B0i1l2FW7&pullRequest=3820

Check failure on line 191 in examples/nokv-shadow-provider/authority_guard.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 19 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaBfJ6iSr27B0i1l2FXH&open=AaBfJ6iSr27B0i1l2FXH&pullRequest=3820

Check failure on line 285 in loopx/control_plane/turn_driver/authority_checkpoint.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 23 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaBfJ6ffr27B0i1l2FW_&open=AaBfJ6ffr27B0i1l2FW_&pullRequest=3820

Check warning on line 71 in loopx/control_plane/turn_driver/authority_checkpoint.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use concise character class syntax '\d' instead of '[0-9]'. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaBfJ6ffr27B0i1l2FW6&open=AaBfJ6ffr27B0i1l2FW6&pullRequest=3820
View more details on SonarQubeCloud