fix(authority): keep event lookup inside control plane - #3938
Conversation
Signed-off-by: huangruiteng <huangrt01@163.com>
|
No blocking finding in the changed surface. Product and architecture judgment
Validation
Python CI exceptionThe complete parallel Python suite was run twice. Both runs reached over 5,600 passing tests, but failed in different pre-existing timing/race-sensitive tests outside this PR's changed module:
The three affected tests pass together locally in five consecutive runs (7/7 each run). Neither failure has a call path to the sole import-boundary edit, and the rerun changing failure identity is further evidence of suite-level flakiness rather than this PR's behavior. Per owner authorization, I am treating only this unrelated required check as an admin-bypass exception; the failure is not concealed or reported as green. Merge decision: self-merge with admin bypass is justified for this narrow post-merge boundary repair. |
Summary
statusfacadeMotivation and design
The authority-shadow drain path needs to confirm whether a prepared event-log entry reached canonical storage. The implementation in #3870 obtained that read helper through
loopx.status, which inverted the intended dependency direction: control-plane coordination depended on a top-level compatibility facade that itself depends on control-plane modules.This patch calls the existing provider-neutral resolver in
control_plane.goalsdirectly. It changes no schema, state, transaction, or candidate-decision behavior.Validation
examples/control_plane/todo-readmodel-boundary-smoke.py: passedmypy: no issues in 21 configured filescqr_6e35a7e0855af76151aa, exact committed diff verifiedPost-merge #3870 CI triage
The merge-commit Full Public Smokes run also reports three failures that reproduce on #3870's base commit: the Todo CLI module-size ratchet, the configure-goal feature-set assertion, and the concise-help line budget. They are pre-existing
mainfailures and are intentionally excluded from this one-file regression fix.Follow-up to #3870.