Skip to content

fix(test): disambiguate pending reply from live announcements #4251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangruiteng merged 1 commit into from
Sep 11, 2026
+9 −1
Merged

fix(test): disambiguate pending reply from live announcements #4251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/development/testing-and-quality.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,12 @@ coverage. 新的前端豁免由目标分支已审阅的策略控制；CI 自身
PRs opened before activation may need a branch update to produce the new
required check; an old green suite alone does not supply a missing aggregate.

Browser waits must target the intended surface: a visible pending-message label
and an accessibility live region may contain the same words. Use a scoped or
exact locator and retain the bounded completion assertion; do not suppress a
strict-mode ambiguity with a retry or a longer timeout. 浏览器等待应区分消息提示与
无障碍播报，不能把定位歧义误报成恢复超时，也不能通过删掉播报来让测试通过。

### Refactor Real-Path Gate / 重构真实路径门

The PR review capability's `observable_semantics` evidence gate applies to
Expand Down
4 changes: 3 additions & 1 deletion examples/personal-workspace-browser-smoke.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2918,7 +2918,9 @@ async function main() {
await page.locator(".personal-goal-link").first().click();
await goalNavigation.getByRole("button", { name: "Chat" }).click();
await page.getByText("保持运行，用于验证刷新恢复。").waitFor({ state: "visible", timeout: 10_000 });
await page.getByText("正在整理…").waitFor({ state: "hidden", timeout: 10_000 });
// The live region also contains "<Agent>: 正在整理…" while a reply is
// pending. Target the visible message placeholder, not both surfaces.
await page.getByText("正在整理…", { exact: true }).waitFor({ state: "hidden", timeout: 10_000 });
const recovered = page.__loopxRuntime.sessions.get(recoveryTurn.sessionId);
if (recovered?.active_turn_id !== null && recovered?.active_turn_id !== recoveryTurn.turnId) {
throw new Error("Recovered Session points at a different active Turn");
Expand Down
Loading