refactor(todo): typed update intent and scope semantics - #4289
Quality Gate failed
Failed conditions
3.9% Duplication on New Code (required ≤ 3%)
Annotations
Check warning on line 211 in loopx/control_plane/coordination/todo_update.ts
sonarqubecloud / SonarCloud Code Analysis
Complete the task associated to this "TODO" comment.
See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaCWfbrxi2WmFx-_crkt&open=AaCWfbrxi2WmFx-_crkt&pullRequest=4289
Check failure on line 276 in loopx/control_plane/todos/mutation_authority.py
sonarqubecloud / SonarCloud Code Analysis
Refactor this function to reduce its Cognitive Complexity from 25 to the 15 allowed.
See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaCah_u4Y9lWA-gfgcUR&open=AaCah_u4Y9lWA-gfgcUR&pullRequest=4289
Check warning on line 80 in loopx/control_plane/todos/update_intent.py
sonarqubecloud / SonarCloud Code Analysis
Function "build_canonical_update_intent" has 29 parameters, which is greater than the 13 authorized.
See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaCWfbY9i2WmFx-_crkq&open=AaCWfbY9i2WmFx-_crkq&pullRequest=4289
Check warning on line 373 in loopx/control_plane/coordination/todo_lifecycle_decision.ts
sonarqubecloud / SonarCloud Code Analysis
Complete the task associated to this "TODO" comment.
See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaCah_0bY9lWA-gfgcUU&open=AaCah_0bY9lWA-gfgcUU&pullRequest=4289
Check failure on line 321 in loopx/control_plane/coordination/todo_update.ts
sonarqubecloud / SonarCloud Code Analysis
Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed.
See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaCah_z4Y9lWA-gfgcUT&open=AaCah_z4Y9lWA-gfgcUT&pullRequest=4289
Check warning on line 334 in loopx/control_plane/coordination/todo_update.ts
sonarqubecloud / SonarCloud Code Analysis
Complete the task associated to this "TODO" comment.
See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaCWfbrxi2WmFx-_crku&open=AaCWfbrxi2WmFx-_crku&pullRequest=4289
Check warning on line 302 in loopx/control_plane/todos/mutation_authority.py
sonarqubecloud / SonarCloud Code Analysis
Complete the task associated to this "TODO" comment.
See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaCah_u4Y9lWA-gfgcUS&open=AaCah_u4Y9lWA-gfgcUS&pullRequest=4289
Check warning on line 133 in loopx/control_plane/todos/authoring_scope.ts
sonarqubecloud / SonarCloud Code Analysis
Extract this nested ternary operation into an independent statement.
See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaCWfbqZi2WmFx-_crkr&open=AaCWfbqZi2WmFx-_crkr&pullRequest=4289
Check warning on line 199 in loopx/control_plane/coordination/todo_update.ts
sonarqubecloud / SonarCloud Code Analysis
'authorityDecision.code ?? "mutation_rejected"' will use Object's default stringification format ('[object Object]') when stringified.
See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaCWfbrxi2WmFx-_crks&open=AaCWfbrxi2WmFx-_crks&pullRequest=4289