Skip to content

refactor(coordination): unify canonical handoff mode authority and recovery - #4304

Merged
huangruiteng merged 3 commits into
mainfrom
codex/canonical-handoff-mode
Sep 13, 2026
Merged

refactor(coordination): unify canonical handoff mode authority and recovery#4304
huangruiteng merged 3 commits into
mainfrom
codex/canonical-handoff-mode

fix(coordination): preserve legacy fence on provider outage

9567086
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Sep 13, 2026 in 1m 55s

Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 56 in tests/control_plane/test_canonical_handoff_mode.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Split this composite assertion into separate assertions. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaCX8kMCQzi-Va3rxlYz&open=AaCX8kMCQzi-Va3rxlYz&pullRequest=4304

Check warning on line 37 in tests/control_plane/test_canonical_handoff_mode.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unify assertion argument order in this file; both "actual first" and "expected first" conventions are used. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaCX8kMCQzi-Va3rxlY3&open=AaCX8kMCQzi-Va3rxlY3&pullRequest=4304

Check warning on line 41 in tests/control_plane/test_canonical_handoff_mode.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Split this composite assertion into separate assertions. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaCX8kMCQzi-Va3rxlYx&open=AaCX8kMCQzi-Va3rxlYx&pullRequest=4304

Check warning on line 59 in tests/control_plane/test_canonical_handoff_mode.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Split this composite assertion into separate assertions. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaCX8kMCQzi-Va3rxlY0&open=AaCX8kMCQzi-Va3rxlY0&pullRequest=4304

Check warning on line 19 in loopx/control_plane/coordination/handoff_mode_policy.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaCX8kIqQzi-Va3rxlYu&open=AaCX8kIqQzi-Va3rxlYu&pullRequest=4304

Check warning on line 479 in loopx/control_plane/todos/handoff_mode.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add logic to this except clause or eliminate it and rethrow the exception automatically. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaCZZcXLwC-YvzveKhc_&open=AaCZZcXLwC-YvzveKhc_&pullRequest=4304

Check warning on line 36 in tests/control_plane/test_canonical_handoff_mode.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Split this composite assertion into separate assertions. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaCX8kMCQzi-Va3rxlYw&open=AaCX8kMCQzi-Va3rxlYw&pullRequest=4304

Check warning on line 63 in tests/control_plane/test_canonical_handoff_mode.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Split this composite assertion into separate assertions. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaCX8kMCQzi-Va3rxlY1&open=AaCX8kMCQzi-Va3rxlY1&pullRequest=4304

Check warning on line 66 in tests/control_plane/test_canonical_handoff_mode.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Split this composite assertion into separate assertions. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaCX8kMCQzi-Va3rxlY2&open=AaCX8kMCQzi-Va3rxlY2&pullRequest=4304

Check warning on line 99 in tests/control_plane/test_shadow_writer_boundaries.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unify assertion argument order in this file; both "actual first" and "expected first" conventions are used. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaCZZcddwC-YvzveKhdA&open=AaCZZcddwC-YvzveKhdA&pullRequest=4304

Check warning on line 53 in tests/control_plane/test_canonical_handoff_mode.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Split this composite assertion into separate assertions. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaCX8kMCQzi-Va3rxlYy&open=AaCX8kMCQzi-Va3rxlYy&pullRequest=4304

Check failure on line 402 in loopx/control_plane/todos/handoff_mode.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 19 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaCZZcXLwC-YvzveKhc-&open=AaCZZcXLwC-YvzveKhc-&pullRequest=4304

Check warning on line 20 in loopx/control_plane/coordination/handoff_mode_policy.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=huangruiteng_loopx&issues=AaCX8kIqQzi-Va3rxlYv&open=AaCX8kIqQzi-Va3rxlYv&pullRequest=4304
View more details on SonarQubeCloud