docs(catalog): add the missing visual model to IP-028 - #4326
Conversation
The pattern template asks every entry for a visual model, and the other 28 entries all carry one between Expected behavior and Bad smell. IP-028 Connector Runtime Boundary was the only entry without it, so the connector runtime boundary had no diagram explaining the access-mode decision. Add a decision tree over the runtime policy the entry already documents: a missing policy fails closed, and access_mode selects between gate projection, a bounded metadata probe, and fixture-only runs. No other wording in the entry changes. Signed-off-by: BigDataDZ <76271875+BigDataDZ@users.noreply.github.com>
huangruiteng
left a comment
There was a problem hiding this comment.
动机
该 PR 补齐 IP-028 Connector Runtime Boundary 缺失的 Visual Model,使目录模板的 29 个条目都具备同样的解释结构。图示把条目已经定义的 access_mode、safe_default 和 fail-closed 规则变成可读的决策树,没有引入新的运行时行为。
改动思路
改动集中在 docs/concepts/interaction-pattern-catalog.md 的 IP-028 详情块,在 State contract 后加入 Mermaid 图,再保留原有 Bad smell 与 Validation。三个分支分别对应私有元数据、公开元数据和合成 fixture,图中没有扩展允许的输入或权限边界。
具体改动
- 仅新增一个文件中的 15 行 Visual Model Mermaid 内容;未改动 IP-028 原有文字或状态契约。
- 独立结构检查确认 29 个 IP 详情块均有 Visual Model,IP-028 的顺序为
State contract → Visual Model → Bad smell → Validation,Mermaid fence 数量为偶数。 interaction-pattern-catalog-smoke.py通过,git diff --check通过;git merge-tree --write-tree origin/main HEAD无冲突。
对主干的风险
没有发现可归因于该 exact head 的阻塞 finding。图示文本与同一条目中的 access_mode/safe_default 值一致,不改变任何 CLI、运行时、权限或默认行为。GitHub 将分支标为 BEHIND 但仍 MERGEABLE,未发现内容冲突。
loopx check --scan-path docs/concepts/interaction-pattern-catalog.md 的整体命令在本机全局 registry 中命中了与本 PR 无关的缺失字段错误;同一结果的 public-boundary scan 为 clean,且目录专用 smoke 与结构检查均通过。因此这是环境基线噪声,不是该文档改动的回归证据。
我的整体评价
没有阻塞 finding。该图是对现有 IP-028 契约的准确、局部且可维护的可视化补全;验证覆盖了目录结构、Mermaid 配对、公共边界和合并可行性。结论:批准该 exact head 4d365fb45d289b255659ca1b1b90a740b4ba8333。
English verdict: APPROVE: Exact head 4d365fb45d289b255659ca1b1b90a740b4ba8333 adds only the missing IP-028 Mermaid visual model, faithfully restates the existing access-mode contract, passes the catalog smoke and structural checks, and has no merge conflict. The repository-wide check hit unrelated registry baseline errors, while its public-boundary scan remained clean; no blocking finding is attributable to this PR.
Summary
Visual Modelsection to IP-028Connector Runtime Boundaryindocs/concepts/interaction-pattern-catalog.md.Expected behaviorandBad smell. IP-028 was the only entry without it, so the connector runtime boundary had no diagram explaining the access-mode decision.access_modeselects between gate projection, a bounded metadata probe, and fixture-only runs.State contractis a valid template item and stays as it is.Issue Or Task
Validation
4d365fb45d289b255659ca1b1b90a740b4ba8333staticpassedloopx check --scan-path docs/concepts/interaction-pattern-catalog.md→ok: True,errors=0,public boundary scan clean: 1 files.unitnot_runTrigger,Expected behavior,Visual Model,Bad smell, andValidation, and IP-028's segment order isTrigger → Expected behavior → State contract → Visual Model → Bad smell → Validation, consistent with the surrounding entries. Mermaid fence pairing stays balanced (98 fences, even). The diagram only restates theaccess_modeandsafe_defaultvalues the entry's ownState contractblock lists; no new behavior is claimed.Frontend / Visual Evidence
Type of Change
LoopX Area
Technical Direction
Core control-plane hardening
Long-horizon benchmark evidence
Operator surface and IM integration
Shared Goal Authority and cross-host coordination
Architecture and research incubator
Target base branch: main