Skip to content

refactor(cli): retire the quota and support-control size pins via cohesive owners #4362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangruiteng merged 1 commit into from
Sep 14, 2026
Merged

refactor(cli): retire the quota and support-control size pins via cohesive owners #4362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions examples/cli-command-module-size-ownership-command-modularization-smoke.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
STARTER_MODULE_LIMITS = {
# Legacy command owners are frozen at their current baseline while each
# cohesive extraction lands; the default budget still catches new growth.
"quota.py": 1118,
"support_control.py": 1015,
"turn.py": 1114,
"todo.py": 1098,
"starter.py": 180,
Expand Down
230 changes: 17 additions & 213 deletions loopx/cli_commands/quota.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,22 +7,20 @@
from ..capabilities.explore.composition_frontier import (
project_live_explore_composition_frontier,
)
from ..capabilities.repository_change_window import (
repository_delivery_interaction_hook,
)
from ..capabilities.periodic_report.pending_intent import (
periodic_report_pending_intent_interaction_hook,
)
from ..capabilities.repository_change_window import (
repository_delivery_interaction_hook,
)
from ..control_plane.effect_runtime import EffectRuntimeRejected
from ..control_plane.quota.cli_projection import (
compact_quota_monitor_poll_cli_payload,
compact_quota_should_run_cli_payload,
)
from ..control_plane.quota.effect_program import SettlementIdentity
from ..control_plane.quota.error_codes import (
HeartbeatReceiptIdentityConflictError,
QuotaCommandValidationError,
QuotaIdentityPreconditionError,
quota_error_code,
)
from ..control_plane.quota.heartbeat_receipt import (
HEARTBEAT_RECEIPT_SCHEMA_VERSION,
Expand All @@ -43,16 +41,10 @@
render_existing_heartbeat_receipt_payload,
)
from ..control_plane.quota.turn_envelope import build_turn_envelope
from ..control_plane.coordination.legacy_writer_fence import (
LegacyCoordinationWriterFenced,
)
from ..control_plane.coordination.local_authority import LocalCoordinationAuthorityUnavailable
from ..control_plane.effect_runtime import EffectRuntimeRejected
from ..control_plane.scheduler.execution_context import (
GUIDED_START_TURN_RUNTIME_PROFILES,
)
from ..control_plane.todos.contract import normalize_todo_id
from ..file_lock import lock_timeout_error_fields
from ..presentation.renderers.quota_event_markdown import (
render_quota_monitor_poll_markdown,
render_quota_slot_preview_markdown,
Expand Down Expand Up @@ -83,6 +75,12 @@
prepare_quota_command_context,
validate_quota_command_context_request,
)
from .quota_failure_report import (
QUOTA_EVENT_KINDS,
quota_failure_payload,
quota_validation_failure_payload,
should_log_quota,
)
from .quota_host_poll import attach_host_poll_receipt
from .quota_monitor_poll import record_quota_monitor_poll_for_cli
from .quota_registration import (
Expand All @@ -99,17 +97,6 @@
None,
]
RolloutEventAppender = Callable[..., dict[str, object]]
QUOTA_EVENT_KINDS = {
"should-run": "quota_should_run",
"monitor-poll": "quota_monitor_poll",
"scheduler-ack": "quota_scheduler_ack",
"scheduler-ack-current": "quota_scheduler_ack",
"scheduler-fail-current": "quota_scheduler_failure",
"spend-slot": "quota_spend",
"void-slot": "quota_void",
}


def _heartbeat_receipt_settlement_bindings(
event: Mapping[str, object],
) -> tuple[str | None, str | None]:
Expand Down Expand Up @@ -146,191 +133,6 @@ def _effective_spend_turn_instance_id(
return payload_turn_id


def _should_log_quota(command: str, payload: Mapping[str, object]) -> bool:
return command in QUOTA_EVENT_KINDS and (
command == "should-run"
or (
bool(payload.get("ok"))
and (
bool(payload.get("appended"))
or bool(payload.get("receipt_repair_required"))
)
)
)


def _verbose_debug_fields(error: Exception, *, verbose: bool) -> dict[str, object]:
if not verbose:
return {}
return {
"verbose_debug": {
"error_type": type(error).__name__,
"error": str(error),
}
}


def _quota_failure_payload(
args: argparse.Namespace,
*,
registry_path: Path,
runtime_root_arg: str | None,
error: Exception,
) -> dict[str, object]:
command = args.quota_command
lock_timeout_fields = lock_timeout_error_fields(error)
verbose_debug = _verbose_debug_fields(
error, verbose=bool(getattr(args, "verbose", False))
)
if command not in QUOTA_EVENT_KINDS:
return {
"ok": False,
"mode": command,
"registry": str(registry_path),
"runtime_root": runtime_root_arg,
"error_code": quota_error_code(error),
"error": "quota collection failed",
"summary": {
"registered_goals": 0,
"health_blockers": 1,
"next_automatic_turn": None,
"states": {},
},
"groups": {},
"health_items": [
{
"goal_id": "loopx-quota",
"status": "quota_collection_failed",
"waiting_on": "codex",
"severity": "high",
"recommended_action": (
"fix quota/status collection before spending automatic compute"
),
"source": "quota",
}
],
**verbose_debug,
**lock_timeout_fields,
}

public_reason = (
str(error)
if isinstance(error, HeartbeatReceiptIdentityConflictError)
else "quota collection failed"
)
payload: dict[str, object] = {
"ok": False,
"mode": command,
"goal_id": args.goal_id,
"decision": "skip",
"should_run": False,
"error_code": quota_error_code(error),
"reason": public_reason,
"state": "blocked_health",
"waiting_on": "codex",
"status": "quota_collection_failed",
"source": "quota",
"recommended_action": (
"fix quota/status collection before spending automatic compute"
),
**verbose_debug,
**lock_timeout_fields,
}
if isinstance(error, QuotaIdentityPreconditionError):
payload.update(
{
"reason": str(error),
"status": "quota_identity_precondition_failed",
"identity_precondition": error.precondition.value,
"recommended_action": error.recommended_action,
}
)
if error.agent_id is not None:
payload["agent_id"] = error.agent_id
elif isinstance(error, (LegacyCoordinationWriterFenced, LocalCoordinationAuthorityUnavailable)):
payload.update(
{
"error_code": error.code,
"reason": str(error),
**error.payload,
}
)
if lock_timeout_fields:
payload["recommended_action"] = "inspect the lock holder before retrying"
if command == "monitor-poll":
payload.update(
{
"source": args.source,
"agent_id": args.agent_id,
"todo_id": args.todo_id,
"target_key": args.target_key,
"result_hash": args.result_hash,
"material_change": bool(args.material_change),
}
)
elif command in {"scheduler-ack", "scheduler-ack-current"}:
payload.update(
{
"agent_id": args.agent_id,
"surface": args.surface,
"state_key": args.state_key,
"applied_rrule": args.applied_rrule,
}
)
elif command == "scheduler-fail-current":
payload.update(
{
"agent_id": args.agent_id,
"surface": args.surface,
"state_key": args.state_key,
"failed_rrule": args.failed_rrule,
"failure_kind": args.failure_kind,
}
)
return payload


def _quota_validation_failure_payload(
args: argparse.Namespace,
exc: QuotaCommandValidationError,
*,
registry_path: Path,
runtime_root_arg: str | None,
) -> dict[str, object]:
command = args.quota_command
if command not in QUOTA_EVENT_KINDS:
return {
"ok": False,
"mode": command,
"registry": str(registry_path),
"runtime_root": runtime_root_arg,
"error_code": "QUOTA_VALIDATION_FAILED",
"error": str(exc),
"summary": {
"registered_goals": 0,
"health_blockers": 0,
"next_automatic_turn": None,
"states": {},
},
"groups": {},
"health_items": [],
}
return {
"ok": False,
"mode": command,
"goal_id": args.goal_id,
"decision": "skip",
"should_run": False,
"error_code": "QUOTA_VALIDATION_FAILED",
"reason": str(exc),
"state": "blocked_validation",
"waiting_on": "codex",
"status": "quota_validation_failed",
"source": "quota",
"recommended_action": "fix the command arguments before retrying",
}


def _quota_renderer(
args: argparse.Namespace,
) -> Callable[[dict[str, object]], str]:
Expand Down Expand Up @@ -554,10 +356,10 @@ def _dispatch_quota_turn_start_hooks(
agent_id=args.agent_id,
)
if args.agent_id:
from ..capabilities.manager_context import turn_start_hook
from ..control_plane.agents.capability_memory import (
extend_turn_start_dispatch as extend_capability_memory_dispatch,
)
from ..capabilities.manager_context import turn_start_hook
from ..control_plane.capability_hooks import dispatch_turn_start_hooks
from ..history import load_registry
from ..paths import resolve_runtime_root
Expand All @@ -576,7 +378,9 @@ def _dispatch_quota_turn_start_hooks(
dispatch[key] = list(dispatch.get(key) or []) + list(context_dispatch.get(key) or [])
for key in ("registered_count", "invoked_count"):
dispatch[key] = int(dispatch.get(key) or 0) + int(context_dispatch.get(key) or 0)
from ..capabilities.periodic_report.cadence_runtime import extend_cadence_turn_start_dispatch
from ..capabilities.periodic_report.cadence_runtime import (
extend_cadence_turn_start_dispatch,
)
dispatch = extend_cadence_turn_start_dispatch(dispatch, registry_path=registry_path,
runtime_root=root, goal_id=args.goal_id, agent_id=args.agent_id)
local_private_state_mutated = any(
Expand Down Expand Up @@ -892,20 +696,20 @@ def handle_quota_command(
payload["status_projection_cache"] = cache_metadata
except QuotaCommandValidationError as exc:
# Only typed CLI validation diagnostics are public-safe by contract.
payload = _quota_validation_failure_payload(
payload = quota_validation_failure_payload(
args,
exc,
registry_path=registry_path,
runtime_root_arg=runtime_root_arg,
)
except Exception as exc: # noqa: BLE001 - CLI fail-safe boundary; error_code is typed below.
payload = _quota_failure_payload(
payload = quota_failure_payload(
args,
registry_path=registry_path,
runtime_root_arg=runtime_root_arg,
error=exc,
)
if _should_log_quota(args.quota_command, payload):
if should_log_quota(args.quota_command, payload):
spend_turn_instance_id = _effective_spend_turn_instance_id(
payload,
heartbeat_turn_id=heartbeat_turn_id,
Expand Down
Loading