Archive original DeepSWE GPT xhigh v1 code and historical results - #4495
gwh6669999 wants to merge 4 commits into
Conversation
Signed-off-by: gwh6669999 <gwh2860667743@gmail.com>
Signed-off-by: gwh6669999 <gwh2860667743@gmail.com>
Signed-off-by: gwh6669999 <gwh2860667743@gmail.com>
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved execution, admission, network-isolation, retry, and result-attribution findings remain.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Preserves the original DeepSWE v1 snapshot while isolating later execution fixes in a revised package.
Changes:
- Documents provenance and result-attribution boundaries.
- Preserves the historical snapshot unchanged.
- Adds revised admission, delivery, retry, networking, and launcher logic.
- Adds offline execution-contract tests; no benchmark rerun is claimed.
File summaries
| File | Summary |
|---|---|
benchmark/deepswe-gptxhigh-versions.md |
Documents provenance and version boundaries. |
benchmark/deepswe-gptxhigh-v1/workspace_delivery.py |
Preserved original delivery logic. |
benchmark/deepswe-gptxhigh-v1/run_loopx_rerun_54_20260908.sh |
Preserved original launcher. |
benchmark/deepswe-gptxhigh-v1/run_five_arms_remaining59_20260910.sh |
Preserved original launcher. |
benchmark/deepswe-gptxhigh-v1/README.md |
Preserved original documentation. |
benchmark/deepswe-gptxhigh-v1/preflight_loopx_rerun.py |
Preserved original preflight. |
benchmark/deepswe-gptxhigh-v1/pier_cn.py |
Preserved original launcher support. |
benchmark/deepswe-gptxhigh-v1/loopx_wen_native_runner.py |
Preserved original native runner. |
benchmark/deepswe-gptxhigh-v1/loopx_heartbeat_supervisor.py |
Preserved original heartbeat support. |
benchmark/deepswe-gptxhigh-v1/loopx_codex_cli_runner.py |
Preserved original CLI runner. |
benchmark/deepswe-gptxhigh-v1/goal_claude.py |
Preserved original adapter. |
benchmark/deepswe-gptxhigh-v1/codex_nosandbox_wrapper.py |
Preserved original wrapper. |
benchmark/deepswe-gptxhigh-v1-revised/workspace_delivery.py |
Validates linked-worktree delivery. |
benchmark/deepswe-gptxhigh-v1-revised/tests/test_execution_contracts.py |
Covers revised execution contracts offline. |
benchmark/deepswe-gptxhigh-v1-revised/run_loopx_rerun_54_20260908.sh |
Runs the revised 54-task launcher. |
benchmark/deepswe-gptxhigh-v1-revised/run_five_arms_remaining59_20260910.sh |
Runs the revised five-arm experiment. |
benchmark/deepswe-gptxhigh-v1-revised/README.md |
Documents the revised package scope. |
benchmark/deepswe-gptxhigh-v1-revised/preflight_loopx_rerun.py |
Validates admission and task manifests. |
benchmark/deepswe-gptxhigh-v1-revised/plain_appserver_runner.py |
Provides plain app-server execution. |
benchmark/deepswe-gptxhigh-v1-revised/pier_cn.py |
Applies harness and network configuration. |
benchmark/deepswe-gptxhigh-v1-revised/loopx_wen_native_runner.py |
Handles native execution and retries. |
benchmark/deepswe-gptxhigh-v1-revised/loopx_heartbeat_supervisor.py |
Provides heartbeat-based continuation. |
benchmark/deepswe-gptxhigh-v1-revised/loopx_codex_cli_runner.py |
Runs CLI segments and delivery checks. |
benchmark/deepswe-gptxhigh-v1-revised/codex_nosandbox_wrapper.py |
Provides the revised Codex wrapper. |
Review details
Suppressed comments (7)
benchmark/deepswe-gptxhigh-v1-revised/codex_nosandbox_wrapper.py:6
- The revised package is documented as having no benchmark results, but this module's top-level docstring states that a run scored
f2p 31/35without identifying the harness/version or labeling it as historical. Because the statement lives insidev1-revised, it can be read as a result attributable to this package and undermines the version/result boundary. Remove the score or explicitly identify its original source and non-attribution status.
LoopX's codex-cli host is the path that works: driven through it, a Turn loop
ran four times on one task, committed a 22 KB patch and scored f2p 31/35. Its
one problem is the sandbox — it always passes `--sandbox <mode>` (or
benchmark/deepswe-gptxhigh-v1-revised/loopx_codex_cli_runner.py:346
- A nonzero
turn run-onceresult only stops here when its JSON payload is empty. Structuredhost_failurerecords for permanent errors such as authentication or quota failures still reach_retry_delay, increment the streak, and launch another model turn even whenhost_failure.retryableis false. Please fail closed for a missing/false retryable marker and only continue this loop for explicitly retryable host failures.
if completed.returncode != 0 and not payload:
break
benchmark/deepswe-gptxhigh-v1-revised/loopx_codex_cli_runner.py:320
- This runner normalizes delivery after every segment, but it never releases the canonical copy after a linked-worktree patch is recovered. If segment 1 recovers patch A into the canonical checkout and the resumed agent adds B in the linked worktree, the next call sees canonical A and linked A+B and returns
ambiguous, preventing the multi-segment Codex CLI arm from ever reaching valid delivery. Carry the selected worktree forward or reset/release the canonical duplicate between segments, as the heartbeat supervisor does.
delivery = normalize_delivery(project, base_sha)
write_receipt(delivery_path, delivery)
todo_state = _todo_state(args, project)
benchmark/deepswe-gptxhigh-v1-revised/loopx_codex_cli_runner.py:304
- This
turn run-oncesubprocess is not wrapped forsubprocess.TimeoutExpired. When a segment exceeds the configured timeout, the exception escapesrun()before the delivery receipt and structured failed result are written, so the launcher exits with a traceback instead of recording a controlled failed segment. Catch the timeout, record it as a failed segment, and finalize or retry through the same bounded path as other failures.
completed = subprocess.run(
command,
cwd=project,
env=env,
capture_output=True,
text=True,
timeout=segment_timeout + 240,
check=False,
)
benchmark/deepswe-gptxhigh-v1-revised/loopx_wen_native_runner.py:142
- The app-server v2
codexErrorInfodiscriminator is camelCase here. Values such asserverOverloadedandrateLimitExceededare therefore classified as non-retryable because this set only contains snake_case aliases, so_terminal_erroraborts a transient provider failure instead of taking the retry path. The canonical Codex classifier handles these variants; normalize or add the aliases before deciding retryability.
retryable = code in {
"rate_limit_exceeded", "overloaded", "server_error", "request_timeout",
"temporarily_unavailable", "httpConnectionFailed", "responseStreamConnectionFailed",
"responseStreamDisconnected", "responseTooManyFailedAttempts",
}
benchmark/deepswe-gptxhigh-v1-revised/loopx_wen_native_runner.py:163
- The native app-server error contract also emits a standalone
method: "error"notification withparams.error(for example, usage-limit failures), but this terminal predicate only recognizesturn/completedand legacyevent_msgevents. Such a failure is ignored by_terminal_error; if the following completion has no embedded error, the runner loses the structured classification and may treat the turn as normal or wait until timeout instead of applying the retry/abort decision. Handle the typederrornotification in the terminal/error path.
terminal = method == "turn/completed" or (
event_type == "event_msg" and payload_type in {"task_complete", "task_completed", "turn_completed"}
)
if not terminal:
return None
turn = params.get("turn") if isinstance(params.get("turn"), Mapping) else {}
for container in (payload, turn, params):
error = container.get("error") if isinstance(container, Mapping) else None
if error is None:
continue
return classify_model_error(error)
return None
benchmark/deepswe-gptxhigh-v1-revised/preflight_loopx_rerun.py:133
tomllibaccepts special floating-point values such asnanandinf; both passtimeout <= 0here. A malformed task can therefore contribute a non-finite agent timeout, andminimum_agent_timeout/the admission comparison can accept or mis-handle it instead of rejecting the task definition. Require a finite positive timeout before appending it to the manifest.
if re.fullmatch(r"[0-9a-fA-F]{7,40}", base) is None or timeout <= 0:
missing.append(task)
- Files reviewed: 29/29 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| for key in ("HTTP_PROXY", "HTTPS_PROXY", "http_proxy", "https_proxy"): | ||
| result[key] = "" |
| launch_pg goal 4393 | ||
| launch_pg plain 4394 |
Signed-off-by: gwh6669999 <gwh2860667743@gmail.com>
Publish the original DeepSWE GPT xhigh v1 source snapshot and historical 113-task summary under
benchmark/deepswe-gptxhigh-v1/. This PR replaces #4466 and now excludes the laterv1-revisedexecution package entirely.本 PR 仅提交旧 v1 的原始代码与结果,不包含正在运行的新 benchmark,也不把后续执行逻辑修复混入历史快照。原始 14 个文件(包括 README)内容及权限完全不变。
The archive matches source subtree
98c262a:benchmark/deepswe-five-armexactly, with Git tree1bc5d2b3b74761a97d34ba3f3612e977fd610340. Only the containing directory name changes. Companion documentation lists provenance, external runtime prerequisites, known original defects, and evidence limits.benchmark/check_deepswe_v1.pyverifies exact archive bytes/modes and Python/Bash syntax without running a benchmark.Validation:
Execution boundary: this original export is not a standalone runnable package. It depends on external launch scripts, task manifests/definitions, the original plain runner, container/network setup, and provider configuration. Known original admission, retry, and launcher defects are deliberately preserved. We do not claim an end-to-end run, reproducibility from this archive alone, or validation of historical scores. The companion note retains the current SSH Goal / Codex CLI withdrawal caveat.
The revised package cited by the previous Copilot review has been removed from the final diff. Its former code remains in prior commit history for separate work; no additional execution changes are proposed here.