Skip to content

fix(peer): stop the hard-cut guard flagging ordinary runtime prose #4531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangruiteng merged 1 commit into from
Sep 16, 2026
Merged

fix(peer): stop the hard-cut guard flagging ordinary runtime prose #4531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions loopx/chat_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ def is_manager_channel(value: Any) -> bool:
def steward_machine_defaults(controller: Any) -> Mapping[str, Any] | None:
"""Return the machine-configured steward defaults this channel reads.

The runtime controller owns the runtime root and therefore the
The runtime controller holds the runtime root and therefore the
machine-configuration store, so the resolution below never re-derives which
document is authoritative. A caller that has no such owner -- a transport
that does not serve the Dashboard, or a test double -- resolves through its
Expand All @@ -213,8 +213,8 @@ def controller_runtime_root(controller: Any) -> Path | None:
def operator_credential_resolution(controller: Any) -> dict[str, Any]:
"""Return the credential-resolved environment and source for one owner.

A key stored from a product surface lives under the runtime root the
controller owns, so the same owner that resolves the machine's steward
A key stored from a product surface lives under the runtime root this
controller resolves, so the same owner that resolves the machine's steward
defaults resolves where the credential came from and what it resolved to. A
controller without that owner -- a transport outside the Dashboard, or a
test double -- resolves to an unread environment, which lets the channel
Expand Down
4 changes: 2 additions & 2 deletions loopx/chat_runtime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,8 +394,8 @@ def _start_adapter(
if manager_profile is not None
else None
),
# The steward channel's executor, model and effort come from the
# machine configuration this controller owns.
# The steward channel's executor, model and effort come from this
# controller's machine configuration.
**(
manager_model_config(
machine_defaults=self.steward_executor_defaults()
Expand Down
Loading