chore(dashboard): ship the rebuilt chat bundle for the Goal-scoped refresh - #4560
Merged
Merged
Conversation
…fresh loopx/web/chat is tracked, so the Goal-scoped refresh in dashboard-page.tsx only reaches an installed LoopX after the bundle is rebuilt and committed. Rebuilt with npm run build:chat from main at 7153f8f. New entry assets/index-67F_HQF0.js; assets/index-iZK4CVmp.js retires, and the previous generation assets/index-CZNb4Zfe.js stays retained for rollback. Signed-off-by: huangruiteng <14976749+huangruiteng@users.noreply.github.com>
huangruiteng
commented
Sep 16, 2026
huangruiteng
left a comment
huangruiteng
left a comment
Collaborator
Author
There was a problem hiding this comment.
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
Exact head reviewed: fd03fc2
动机
loopx/web/chat 是 git-tracked 的 chat 呈现 bundle。上一刀（#4559，已合并 7153f8f）改了渐进加载的刷新语义，但已安装的 LoopX 仍提供旧 bundle，暂停 Goal 之后依旧整屏重载。缺这一刀，#4559 不生效。
改动思路
只做"把已合并源码变更带给已安装产物"：重建、轮转保留代次、更新入口。bundle 内容完全由含 #4559 的 origin/main 决定；审查面是生成物与声称源码的一致性。
具体改动
- 运行 npm run build:chat（= tsc --noEmit && vite build --config vite.chat.config.ts）。
- 新入口 loopx/web/chat/assets/index-67F_HQF0.js；退役 assets/index-iZK4CVmp.js。
- assets/index-CZNb4Zfe.js 保留为上一代可回滚代次；index.html 与 asset-retention.json 随轮转更新；CSS 入口未变。
对主干的风险
低。生成物提交，无运行时、契约、权限或投递语义变更。保留上一代使已加载旧页面的客户端仍可拉取其 JS。
我的整体评价
正向且 proportional：#4559 的必要配套，单独成 PR 便于独立回滚。
Evidence:
- exact head fd03fc2
- npm run build:chat: passed（内建 tsc --noEmit 通过）
- python3 examples/dashboard-pwa-bundle-smoke.py: ok
- 产物核对：新 bundle 含源改动标记「正在连接管家」；asset-retention.json 恰两代且含上一代 JS；磁盘上两代 JS 均存在
- loopx canary premerge --from-git-diff: merge_gate_passed true, surfaces general；advisory 为 clean origin/main 已知基线
- 合并后将重新 promote 本机安装并做 HTTP 读回
English verdict: APPROVE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
动机
loopx/web/chat是 git-tracked 的 chat 呈现 bundle。上一刀（#4559，已合并 7153f8f）改了渐进加载的刷新语义，但已安装的 LoopX 仍提供旧 bundle，暂停 Goal 之后依旧整屏重载。缺这一刀，#4559 不生效。改动思路
只做"把已合并源码变更带给已安装产物"：重建、轮转保留代次、更新入口。bundle 内容完全由含 #4559 的
origin/main决定。具体改动
npm run build:chat（tsc --noEmit && vite build --config vite.chat.config.ts）。loopx/web/chat/assets/index-67F_HQF0.js；退役assets/index-iZK4CVmp.js。assets/index-CZNb4Zfe.js保留为可回滚代次；index.html与asset-retention.json随轮转更新；CSS 入口未变。对主干的风险
低。生成物提交，无运行时、契约、权限或投递语义变更。保留上一代使已加载旧页面的客户端仍能拉取其 JS。
我的整体评价
正向且 proportional：#4559 的必要配套，单独成 PR 便于独立回滚。
Validation:
npm run build:chat成功（内建tsc --noEmit通过）。python3 examples/dashboard-pwa-bundle-smoke.py→ ok。asset-retention.json恰两代且含上一代 JS；磁盘上两代 JS 均存在。loopx canary premerge --from-git-diff→merge_gate_passed: true，surfacesgeneral；advisory 为 cleanorigin/main已知基线。Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
English verdict: APPROVE