chore(dashboard): ship the rebuilt chat bundle for the settings categories - #4564
Merged
Merged
Conversation
…ories loopx/web/chat is tracked, so the settings-category split and the layout repair in personal-workspace.css only reach an installed LoopX after the bundle is rebuilt and committed. Rebuilt with npm run build:chat from main at 18539ea. New entry assets/index-DWWKKUgg.js with the matching stylesheet assets/index-DWmuPX72.css; assets/index-CZNb4Zfe.js retires, and the previous generation assets/index-67F_HQF0.js with assets/index-B21-YvBH.css stays retained. Signed-off-by: huangruiteng <14976749+huangruiteng@users.noreply.github.com>
huangruiteng
commented
Sep 16, 2026
huangruiteng
left a comment
Collaborator
Author
There was a problem hiding this comment.
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
Exact head reviewed: c101b1f
动机
loopx/web/chat 是 git-tracked 的 chat 呈现 bundle。上一刀(#4563,已合并 18539ea)改了设置页信息架构与布局,但已安装的 LoopX 仍提供旧 bundle:重叠仍在、左栏仍是单项。缺这一刀,#4563 不生效。
改动思路
只做"把已合并源码变更带给已安装产物":重建、轮转保留代次、更新入口与样式表。bundle 内容完全由含 #4563 的 origin/main 决定;审查面是生成物与声称源码的一致性。
具体改动
- 运行 npm run build:chat(= tsc --noEmit && vite build --config vite.chat.config.ts)。
- 新入口 loopx/web/chat/assets/index-DWWKKUgg.js + 配套样式表 assets/index-DWmuPX72.css(本次含 CSS 变更,样式表文件名随之轮转)。
- 退役 assets/index-CZNb4Zfe.js;上一代 assets/index-67F_HQF0.js 与 assets/index-B21-YvBH.css 保留为可回滚代次。
- index.html 与 asset-retention.json 随轮转更新。
对主干的风险
低。生成物提交,无运行时、契约、权限或投递语义变更。保留上一代使已加载旧页面的客户端仍能拉取其 JS 与 CSS。
我的整体评价
正向且 proportional:#4563 的必要配套,单独成 PR 便于独立回滚。
Evidence:
- exact head c101b1f
- npm run build:chat: passed(内建 tsc --noEmit 通过)
- 产物核对:新 JS 含 settings.modelProvider;新 CSS 含 personal-capability-body;asset-retention.json 恰两代且两代 JS/CSS 均在磁盘上
- python3 examples/dashboard-pwa-bundle-smoke.py: ok
- loopx canary premerge --from-git-diff: merge_gate_passed true, surfaces general;advisory 为 clean origin/main 已知基线
- 合并后将重新 promote 本机安装并用同一探针复测 spill 与重叠为空
English verdict: APPROVE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
动机
loopx/web/chat是 git-tracked 的 chat 呈现 bundle。上一刀(#4563,已合并 18539ea)改了设置页的信息架构与布局,但已安装的 LoopX 仍提供旧 bundle:重叠仍在、左栏仍是单项。缺这一刀,#4563 不生效。改动思路
只做"把已合并源码变更带给已安装产物":重建、轮转保留代次、更新入口与样式表。bundle 内容完全由含 #4563 的
origin/main决定。具体改动
npm run build:chat(tsc --noEmit && vite build --config vite.chat.config.ts)。loopx/web/chat/assets/index-DWWKKUgg.js+ 配套样式表assets/index-DWmuPX72.css(本次改动含 CSS,故样式表文件名也随之轮转)。assets/index-CZNb4Zfe.js;上一代assets/index-67F_HQF0.js与assets/index-B21-YvBH.css保留为可回滚代次。index.html与asset-retention.json随轮转更新。对主干的风险
低。生成物提交,无运行时、契约、权限或投递语义变更。保留上一代使已加载旧页面的客户端仍能拉取其 JS 与 CSS。
我的整体评价
正向且 proportional:#4563 的必要配套,单独成 PR 便于独立回滚。
Validation:
npm run build:chat成功(内建tsc --noEmit通过)。settings.modelProvider;新 CSS 含personal-capability-body;asset-retention.json恰两代且两代 JS/CSS 均在磁盘上。python3 examples/dashboard-pwa-bundle-smoke.py→ ok。loopx canary premerge --from-git-diff→merge_gate_passed: true,surfacesgeneral;advisory 为 cleanorigin/main已知基线。spill与重叠应为空。Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
English verdict: APPROVE