Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,21 @@ adapters, smoke tests, public docs, or commit/push workflows, use the
For small, low-risk PRs, maintainers may self-merge after validation when all
of the following are true:

Here, "自合并" means: 自己 review/refine, then admin-bypass merge after the
required validation and authorization.
Here, "自合并" means: 自己 review/refine, publish that review on the exact head,
then admin-bypass merge after the required validation and authorization. A
self-merge whose head carries no published review is a process gap, not a
smaller form of review: repair it by publishing the exact-head review for the
merged commit and correcting the rule that let it through.

- the PR only touches public docs, contributor metadata, or narrow cleanup;
- the change is single-purpose and easy to review from the diff;
- required checks or focused smokes have passed;
- the exact head carries a published self-review, and
`loopx pr-review --check-merge-readiness NUMBER@HEAD_OID` returned ready for
that unchanged head. GitHub blocks formal self-approval, so on an
author-owned PR the record is a `COMMENTED` review on the exact head that
states the approval conclusion and an English verdict; a green CI run, a diff
read, or the merge itself is not that record;
- private state, raw benchmark evidence, credentials, local paths, and
generated logs are excluded;
- there is no runtime behavior, benchmark adapter, permission, destructive git,
Expand Down
7 changes: 6 additions & 1 deletion skills/loopx-pr-merge/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,12 @@ then reports separately authorized admin bypass, never permission to merge.
4. Decide: approve, self-merge with owner authorization, request changes, or
hold for the maintainer path. Record the decision on the pull request with
the changed surfaces, the checks that ran, failures and skips, manual holds,
and the reason that coverage is enough.
and the reason that coverage is enough. Record it as a published review on
the exact head, not as a summary in another channel: on an author-owned PR
GitHub blocks formal self-approval, so the record is the `COMMENTED` review
carrying the approval conclusion and the English verdict. A self-merge whose
head carries no such record is a process gap to repair, not an authorized
merge.
5. After the merge, sync the local default branch, leave unrelated dirty
worktree state alone, and update LoopX todo or evidence when the work is
tracked.
Expand Down
Loading