Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions examples/control_plane/todo-first-open-summary-smoke.py
Original file line number Diff line number Diff line change
Expand Up @@ -217,24 +217,34 @@ def build_blocked_priority_fallback_status_payload() -> dict:
}


def assert_blocked_priority_fallback_visible() -> None:
def assert_blocked_priority_fallback_notice_visible() -> None:
"""A blocked higher-priority todo is announced, but it never gates delivery.

Informing the owner and requiring owner action are different decisions, and
only the first one changed: the fallback still runs, `requires_user_action`
and the interactive user channel's `action_required` stay false, and the
markdown readback says the notice instead of the old silent default.
"""

decision = build_quota_should_run(
build_blocked_priority_fallback_status_payload(),
goal_id=GOAL_ID,
agent_id="codex-main-control",
)
assert decision["should_run"] is True, decision
fallback = decision["blocked_priority_fallback"]
assert fallback["notify_user"] is False, fallback
assert fallback["notify_user"] is True, fallback
assert fallback["requires_user_action"] is False, fallback
assert fallback["blocked_items"][0]["text"] == BLOCKED_CORE_TODO, fallback
assert fallback["selected_executable"]["text"] == FALLBACK_TODO, fallback
assert decision["heartbeat_recommendation"]["notify"] == "DONT_NOTIFY", decision
assert decision["heartbeat_recommendation"]["notify"] == "NOTIFY", decision
user_channel = decision["interaction_contract"]["user_channel"]
assert user_channel["action_required"] is False, user_channel
assert user_channel["notify"] == "DONT_NOTIFY", user_channel
assert user_channel["notify"] == "NOTIFY", user_channel
assert "no owner action is required" in user_channel["reason"], user_channel
markdown = render_quota_should_run_markdown(decision)
assert "blocked_priority_fallback: notify_user=False" in markdown, markdown
assert "blocked_priority_fallback: notify_user=True" in markdown, markdown
assert "no owner action is required" in markdown, markdown
assert f"blocked_priority_item[1]: {BLOCKED_CORE_TODO}" in markdown, markdown
assert f"blocked_priority_selected: {FALLBACK_TODO}" in markdown, markdown

Expand Down Expand Up @@ -788,7 +798,7 @@ def main() -> int:
], packet
assert f"Agent 待办:{APPENDED_P0_TODO}" in packet["project_agent_handoff"], packet
assert f"Agent 待办候选 2:{OPEN_TODO}" in packet["project_agent_handoff"], packet
assert_blocked_priority_fallback_visible()
assert_blocked_priority_fallback_notice_visible()
assert_claimed_frontstage_lanes_visible()
assert_project_asset_claimed_counts_use_lane_fallback()
assert_claimed_markdown_todos_survive_visibility_lanes()
Expand Down