Skip to content

fix(smokes): restore the two public smoke contracts broken on main #4681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangruiteng merged 1 commit into from
Sep 18, 2026
Merged

fix(smokes): restore the two public smoke contracts broken on main #4681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/reference/protocols/goal-vision-replan-contract-v0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,9 @@ is its `schema_version`, not its enclosing field. The shared TypeScript authorin
boundary rejects misplaced declared deltas before any write, including through
CLI and Turn. It does not infer a protocol from ordinary metadata field names.
Existing packets may omit the nested schema version; an explicitly supplied
version must match. Historical read compaction remains unchanged.
version must match. The look-back rides the existing `--agent-vision-json`
boundary, so it stays explicit without adding more inline CLI flags or expanding
the heartbeat prompt. Historical read compaction remains unchanged.

```json
{
Expand Down
5 changes: 4 additions & 1 deletion examples/blocker-push-runtime-smoke.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,10 @@ def main() -> int:
assert "reuse the value on retries" in compact_prompt, prompt
assert "guard; 2 stalls->replan" in compact_prompt, prompt
assert "no-change=`surface_only`/no spend" in compact_prompt, prompt
assert "unchanged->`--vision-unchanged-reason`" in compact_prompt, prompt
# The shipped writeback sentence moved to the mixed-language form in the
# same change that updated examples/control_plane/heartbeat-prompt-smoke.py;
# this assertion keeps the blocker-runtime path pinned to the same text.
assert "unchanged→真实`--vision-unchanged-reason`" in compact_prompt, prompt

print("blocker-push-runtime-smoke ok")
return 0
Expand Down
Loading