Skip to content

test(update-notes): stop pinning the pre-transfer repository address #4809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangruiteng merged 1 commit into from
Sep 20, 2026
Merged

test(update-notes): stop pinning the pre-transfer repository address #4809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion examples/update-notes-generator-quality-smoke.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ def fake_run_git(args: list[str]) -> str:


def validate_compact_ranking(module) -> None:
# Pinned once, here, as the canonical address the generator must publish.
# Every other expectation in this smoke composes from ``module.PULL_URL`` so a
# future repository move cannot silently re-break a hand-copied bullet.
assert module.PULL_URL == "https://github.com/loopx-project/loopx/pull"
commits = [
module.Commit("a", "docs: explain issue-fix", 40),
module.Commit("b", "fix: preserve issue-fix evidence", 39),
Expand All @@ -72,7 +76,7 @@ def validate_compact_ranking(module) -> None:
ranked = grouped["Issue-fix workflow"]
assert [item.pr_number for item in ranked] == [38, 39, 40], ranked
bullets = module.bulletize(ranked, limit=2)
assert bullets[0].startswith("- [#38](https://github.com/huangruiteng/loopx/pull/38)"), bullets
assert bullets[0] == f"- [#38]({module.PULL_URL}/38) feat: add issue-fix lifecycle"
assert bullets[-1] == "- ...and 1 more merged PR in this theme.", bullets
note = module.render_note(
module.Window(module.parse_date("2026-07-01"), module.parse_date("2026-07-14")),
Expand Down