fix(settings): restore machine capability catalog after editor kind drift - #5009
Merged
Merged
Conversation
Signed-off-by: huangruiteng <14976749+huangruiteng@users.noreply.github.com>
Signed-off-by: huangruiteng <14976749+huangruiteng@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal and gap
Restore the machine capability settings page when the shared catalog includes the Goal-only progress-review descriptor. The API returned registered machine capabilities, but the dashboard rejected the entire catalog because
progress_review.drift_thresholdused an editor kind outside the browser's published vocabulary. The machine page then displayed a false empty-registry message.Change
numbereditor kind for the integer-bounded drift threshold. Its minimum, maximum, and server-side integer validation remain authoritative.User entry points and visual evidence
Validation
uv run --extra test python -m pytest tests/capabilities/test_capability_configuration_ui.py tests/capabilities/test_progress_review.py -q— 23 passed.npm run build— TypeScript, Dashboard, and packaged Chat bundle passed.LOOPX_PERSONAL_WORKSPACE_PACKAGED=1 ... node examples/personal-workspace-browser-smoke.mjs(typed-actions) — passed on the exact branch head.git diff --check, and LoopX public-boundary check — passed. The LoopX check reported two pre-existing active-state projection warnings unrelated to these files.Scope and review
This changes the capability catalog contract and the shipped Dashboard. Leave merge to the maintainer after exact-head review. The adjacent editor vocabulary was checked as a bounded future-facing pass; no additional abstraction was needed.