Conversation
Signed-off-by: liuhuadong.hans <liuhuadong.hans@bytedance.com>
Signed-off-by: liuhuadong.hans <liuhuadong.hans@bytedance.com>
…visions Signed-off-by: liuhuadong.hans <liuhuadong.hans@bytedance.com>
Signed-off-by: liuhuadong.hans <liuhuadong.hans@bytedance.com>
maxliux5
left a comment
There was a problem hiding this comment.
Exact-head review: ad478f4 (base f49b4a0).
Verdict: APPROVE for the explicitly scoped experimental CLI slice. Full RFC M1 acceptance remains OPEN. Maintainer review/merge required; no self-merge.
Standards and Spec review both examined this head. Source reread is inside the service boundary; source edits retain stable Todo identity; registry admission proves empty registration instead of fabricating facts. Active state, exact instance, runtime binding, registry witness and canonical CAS/receipts bound mutations. The final pagination-revocation case rejects without a second read or provider revision change. No unresolved correctness blockers were identified within the documented CLI scope.
Changed surfaces: opt-in CLI/model orchestration, bundled read-only Lark adapter, private review handoffs and canonical Todo caller integration. Existing desktop, shared reducers and default runtime paths are unchanged. Disabled mode performs no provider/model effects. Source text cannot authorize sends, completion or execution; caller-supplied owner identity still needs live verification.
Validation: primary run 91 focused tests passed; Spec reviewer independently reran the nine feature tests on this head. Full-suite 21 failures reproduced on the unchanged baseline; typecheck has the identical 53 baseline diagnostics. Public/private and whitespace scans passed. Lark/model test doubles, missing live qualification, durable proposal lifecycle and packaged desktop readback are explicit manual holds. Focused coverage is sufficient for review of this experimental slice, not release qualification.
Future-facing pass reused canonical registry witness, typed exact Goal identity and existing mutation owners. No new permission reducer, scheduler or Todo database was introduced. Unsupported registry profiles fail closed until the shared registry owner is extended with parity evidence.
Selected Lark text can now be turned into explicitly reviewed canonical User Todo changes through an opt-in TypeScript/Node CLI. The workflow prepares bounded model proposals, exposes a review digest, rechecks source and registry authority before applying, and reads persisted Todos back. Exact retries use canonical receipts; a changed deadline amends the same Todo. Multi-item reviews can refresh against the new canonical revision without another model request.
This is an experimental CLI prerequisite, partial RFC M1, following #5384. It does not ship the desktop personal-agent journey. Review files are private transient CLI handoffs; the existing desktop proposal lifecycle and installed UI still need typed integration. The draft remains held for maintainer review and live qualification.
Scope and authority:
Validation:
f49b4a0(missing checkout examples and existing runtime/test issues). Final fixes were revalidated with the focused set.f49b4a0, with no added/removed diagnostics after path normalization. This is not a green repository-wide typecheck.Future-facing pass: reuse canonical receipts, source witness and typed Goal parsing; keep narrow registry admission local until the shared registry owner can support more profiles. Shared mutation and permission reducers are unchanged. Next owner: personal-workspace/work-items with the Lark extension for durable proposals, packaged desktop return and live qualification under the existing RFC. No self-merge.