test: register dynamic decision reference matcher in digest census - #5499
Conversation
Signed-off-by: huangruiteng <huangrt01@163.com>
huangruiteng
left a comment
There was a problem hiding this comment.
Reviewer: model_agent; model: GPT-6; provider: OpenAI
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
Exact head: da410099a6ea4a6b3dc2c5a80d86f8eafabb2482; immutable base: 5c1cdbcd8bf9924609b7bfbfe508a5c742ebe720.
动机
准备发布的维护者需要区分真正重复的摘要规则与正确的运行时请求引用检查。
新通知按请求 ID 检查完整引用,摘要普查无法静态计算这个 ID,因此把未登记的构造报为失败;补全已有登记后,它可以继续检查所有真正的摘要重复。
实际 base 重现未登记失败,当前 head 的完整摘要普查和既有通知引用测试共 24 项通过,类型检查通过。
本 PR 只登记一处已存在的非摘要正则,不改变通知、批准、遥测、持久数据或完整发布资格。
没有单独的登记表规格;本评审以既有普查规则和请求引用测试为依据,不把作者描述当作独立规格。
改动思路
复用 DECLARED_UNFOLDABLE,为 control_plane/presentation/decision_notice.ts 的一个动态构造登记具体用途。它插入经过转义的请求 ID,并核对标识边界;不是整值 SHA-256 规则。静态普查的摘要拒绝、可见 64-hex 拒绝、精确路径/数量及 canonical consumer 检查均保留。
具体改动
唯一改动是测试文件中的四行登记,count: 1,说明它是 escaped request identifier。生产 validateDecisionNoticeReferences、通知投影及共享摘要 owner 均未改动。完整 ID、Markdown/标点、前后缀拒绝和 legacy.ref+1 转义反例沿用既有测试,未新增重复 smoke。
对主干的风险
风险是登记掩盖实际摘要重复;当前 scanner 仍先拒绝可见摘要形状,再核对精确 path/count,相关变异测试通过。无新 enum、默认开关、权限、状态、入口或 machine obligation 变化;frontend/Lark/CLI 没有新增伴随动作,生产文件相对 base 完全相同。回退只删这四行,不涉及数据迁移。
我的整体评价
APPROVE。这是完整、可逆的测试普查修复。base 重现缺项失败;head 的 24 项摘要与通知检查、完整 control-plane typecheck、精确范围 quality 有效;native 风险选择未选 catalog smoke,三个直接 diff 检查通过。24 项领域测试补齐此测试变更的验证,零相关失败或跳过。CI 按当前 Goal 配置未查询。未来 refactor 检查保留既有 owner/table,无需新抽象。整版发布仍需在最后冻结源码上独立取得全量资格,不能继承本 PR 通过记录。
English verdict: APPROVE - da410099a6ea4a6b3dc2c5a80d86f8eafabb2482. Register the one existing dynamic exact-reference matcher in the current non-digest census. Digest rejection and product behavior remain unchanged; 24 focused checks, typecheck and exact-scope native validation passed.
The existing digest ownership census rejects the dynamic exact-request-reference matcher introduced by #5480 because it cannot fold a runtime request ID. Register that one non-digest construction with its concrete purpose in the existing declaration table. Whole-value digest rejection, consumer pinning and production notice matching are unchanged.
Validation: the immutable base reproduces the missing-declaration failure. The final head runs the complete digest census and existing decision notice tests, including request prefix/suffix rejection and escaped literal references, plus the control-plane typecheck and native risk premerge. Exact-head self-review and merge readiness are required before merging. This test-only repair does not qualify the complete release.