Add ability to provide custom comment when Ack-ing a service alert. Provide a fix for issue #50.#57
Open
brennentsmith wants to merge 2 commits into
Open
Add ability to provide custom comment when Ack-ing a service alert. Provide a fix for issue #50.#57brennentsmith wants to merge 2 commits into
brennentsmith wants to merge 2 commits into
Conversation
brennentsmith
changed the title
brennentsmith
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides the ability for users to submit a custom comment when Ack-ing a service alert - we use this heavily at Ookla so the team knows why and who is handling an alert. If the field is left blank, the comment will fall back onto the default nagdash comment. Screenshot of UI change is here: http://ookla.d.pr/17KI1
Also provide a fix for: #50