fix build cross-platform#1
Open
giangndm wants to merge 6 commits into
Open
Conversation
|
@giangndm With this, it should be possible to build this crate and link dynamically to the soxr DLL on Windows, right? |
Author
|
@Boscop I only tested in mac and linux env. Did it error with Windows? |
lrbalt
reviewed
Apr 23, 2026
| @@ -0,0 +1,3 @@ | |||
| [submodule "soxr"] | |||
| path = soxr | |||
| url = https://github.com/chirlu/soxr | |||
Owner
There was a problem hiding this comment.
Can we do without this submodule? I'd rather not reference a personal repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add build from Soxr source fallback incase of pkg-config cannot find libsoxr.
The motivation of this PR is to build cross-platform versions with github-actions. Example with macOS aarch64, pkg-config cannot find library with macos-lastest x64 runner.