Text Exercise: Integrate the new Athena - #174
Open
terlan98 wants to merge 43 commits into
Open
Conversation
…tum/Themis into feature/text/new-athena
terlan98
marked this pull request as ready for review
August 30, 2023 17:33
terlan98
marked this pull request as draft
September 10, 2023 07:13
terlan98
marked this pull request as ready for review
September 10, 2023 08:01
…ture/text/new-athena
…ture/text/new-athena
terlan98
changed the title
Text Exercises: Integrate the new AthenaText Exercise: Integrate the new Athena
Conflicts: Themis.xcodeproj/project.pbxproj
terlan98
marked this pull request as draft
October 26, 2023 08:30
terlan98
marked this pull request as ready for review
October 26, 2023 17:33
Member
|
Should the changes to the |
Contributor
Author
No, I'm not sure how they ended up in this PR 😅. I removed them with a new commit. |
Conflicts: Themis/ViewModels/Assessment/Programming/CodeEditorViewModel.swift
Conflicts: Themis.xcodeproj/project.pbxproj Themis/Views/Assessment/CorrectionSidebar/EditFeedback/EditFeedbackViewBase.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates the new Athena implementation for text exercises into Themis.
Can be tested on https://ma-schwind.ase.cit.tum.de/ with Athena Test Course 2 (make sure
feature/programming-exercises/feedback-suggestions-serveris deployed)The text blocks with feedback suggestions are indicated with underline:
The user can tap on such blocks and accept or dismiss the suggestion
Suggested feedbacks are shown with a badge in correction sidebar:
