Support more spec organizations and 1.8.6 fix#3
Open
kputnam wants to merge 2 commits intolsegal:masterfrom
kputnam:master
Open
Support more spec organizations and 1.8.6 fix#3kputnam wants to merge 2 commits intolsegal:masterfrom kputnam:master
kputnam wants to merge 2 commits intolsegal:masterfrom
kputnam:master
Conversation
added 2 commits
January 20, 2011 14:33
-- Arbitrary nesting is supported, with contexts inside or outside the
describe "#method" blocks. The first argument to describe must be
a class, nested class, instance "#method" or class ".method"
-- Ignore argument list for describe "#method(a, b = nil, &c)" etc so we
match the right AST node
-- Support for pending specs (specs without a body)
-- Support for its(:property) { ... }, it { ... }, and specify { ... }.
The spec description is guessed from the content of the block
-- Ignores RSpec metadata like :pending => true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've fixed the template issue so everything is 1.8.6-compatible. I've also extended the parsers (both 1.8 and 1.9 versions) to support a wider number of specs. This change is not compatible with the two forks that also extend the parsers to support "context" and friends, but I believe it is more complete and possibly can accommodate both use cases.
This patch adds support for pending specs, nested contexts, nested describes, argument lists in the method description, and default spec titles for unnamed specs (both in 1.8 and 1.9).
Closes #1
Closes #2