DM-53963: Calculate image/patch overlap in patch coordinates #449
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
approved these changes
Jan 29, 2026
erykoff
reviewed
Jan 29, 2026
Contributor
erykoff
left a comment
erykoff
left a comment
There was a problem hiding this comment.
It is probably worth adding a comment that we are projecting the detector into the patch (using the well defined patch WCS) which is more stable than projecting the patch into the detector coordinates (using the not-happy-to-be-extrapolated detector WCS)
cmsaunders
force-pushed
the
tickets/DM-53963
branch
from
0383290 to
b5a2b39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.