tickets/SP-2754: add no_sky=True to ModelObservatory wherever possible#180
Merged
Conversation
rhiannonlynne
approved these changes
Nov 8, 2025
rhiannonlynne
left a comment
Member
There was a problem hiding this comment.
I tested this with the night summary locally and it works! (for the visit maps, is the use-case I was interested in, in particular).
rhiannonlynne
force-pushed
the
tickets/SP-2754
branch
from
November 8, 2025 04:53
18179c3 to
8369e54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In many cases,
schedviewcreates instances ofModelObservatorythat do not need sky brightness, and this change adds theno_sky=Trueflag when these are instantiated.In some cases, however, the sky brightness is used, in particular when maps of sky brightness are created (as in the scheduler snapshot dashboard) and when the values of basis functions are computed.
Even for these cases, it is still possible to use
schedviewwithout local copies of sky brightness pre data files, if:SIMS_SKYBRIGHTNESS_DATAenvironment variable is set to a URL under which sky brightness files can be found, for examplehttps://s3df.slac.stanford.edu/groups/rubin/static/sim-data/sims_skybrightness_pre/h5_2023_09_12_small/lsst.resourcespath can be importedIn this case, sky brightness data will be downloaded from the USDF as needed. (This is how the schedview snapshot dashboard does it.) It is, however, much slower than using local files, particularly from IP addresses that are not at SLAC.