Skip to content

Use binary for psycopg2 from pypi and allow lower rubin_scheduler#194

Closed
rhiannonlynne wants to merge 1 commit into
mainfrom
u/lynnej/schedview_reqs
Closed

Use binary for psycopg2 from pypi and allow lower rubin_scheduler#194
rhiannonlynne wants to merge 1 commit into
mainfrom
u/lynnej/schedview_reqs

Conversation

@rhiannonlynne

Copy link
Copy Markdown
Member

to pip install lsst-survey-sim in GitHub, the dependency on psycopg2 has to be the binary version.
I'm not sure why we didn't use Psycopg instead (equivalent to psycopg 3) .. but also these dependencies are maybe in some of the wrong places.

I put rubin_scheduler down to the summit value, but I'm not entirely sure that's correct .. it's a thing though that makes it easier to pip install lsst-survey-sim.

@ehneilsen

Copy link
Copy Markdown
Collaborator

We use psycopg2 instead of psycopg(3) because I haven't gone through the code and made the necessary changes for the v3 API.

@ehneilsen

Copy link
Copy Markdown
Collaborator

Yes, I think the dependency here may not be necessary, but I think the install options for rubin_sim in the lsst_survey_sim dependencies will need to be updated if we take the psycopg2 dependency out of schedview.

@rhiannonlynne

Copy link
Copy Markdown
Member Author

You know - I realized that I was confused; lsst_survey_sim does NOT depend on schedview, so the requirements do not have to match here.
I think I can just close this PR without merging, as unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants