tickets/SP-2995: Add VisitMapBuilder to replace create_visit_skymaps#195
Merged
Conversation
Collaborator
Author
|
The tests will not pass until the corresponding uranography PR is merged and tagged. |
emanehab99
approved these changes
Mar 5, 2026
emanehab99
left a comment
emanehab99
left a comment
Collaborator
There was a problem hiding this comment.
This looks great. Thanks for updating the notebook with various examples and usecases. Also the docstring covers all details needed for using the builder.
ehneilsen
force-pushed
the
tickets/SP-2995
branch
from
March 16, 2026 20:35
e37f28d to
7bf7ea1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_visit_skymaps was too inflexible to support the nightly digest without forking.
The refactor reworks the implementation to make it sufficiently flexible to support multiple uses.
See this slack thread for discussion.