Skip to content

tickets/SP-3045: Remove unused functions to reduce/remove collect dependencies in plot#199

Merged
ehneilsen merged 1 commit into
mainfrom
tickets/SP-3045
Apr 2, 2026
Merged

tickets/SP-3045: Remove unused functions to reduce/remove collect dependencies in plot#199
ehneilsen merged 1 commit into
mainfrom
tickets/SP-3045

Conversation

@ehneilsen

Copy link
Copy Markdown
Collaborator

No description provided.

@ehneilsen
ehneilsen requested a review from rhiannonlynne March 30, 2026 17:27

@rhiannonlynne rhiannonlynne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know better than I where these were being used, but it might be good to comment which functions were removed and what people could use alternatively (in a comment in the PR perhaps).

@ehneilsen

Copy link
Copy Markdown
Collaborator Author

The removed functions are:

  • create_survey_reward_plot
  • create_visit_explorer

To my knowledge, these are currently unused anywhere. In both cases, the functions are combinations of collect/compute/combine steps implemented in other functions. When the reward plot made by create_survey_reward_plot is made currently (in the prenight briefing notebook), the notebook itself calls the various underlying functions directly, not this driver. The create_visit_explorer function was only ever an exploration tool, and is better called through underlying functions as well.
Note that these functions mildly violate the high-level architecture of schedview, and this violation was the cause of the issues encountered that led to the jira issue being filed. If similar functionality is desired in the future, it should be implemented outside of the schedview.plot sub-module.

@ehneilsen
ehneilsen merged commit 2e25ff8 into main Apr 2, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants