SP-3256: Add function to fetch dayobs-downtime summary#205
Open
rhiannonlynne wants to merge 2 commits into
Open
SP-3256: Add function to fetch dayobs-downtime summary#205rhiannonlynne wants to merge 2 commits into
rhiannonlynne wants to merge 2 commits into
Conversation
Collaborator
|
Can you add a simple pytest or unittest? You can (probably should) make it get skipped by default do it doesn't get run by github CI (see what I do in tests/test_efd.py). |
Member
Author
|
Test added, follows your key for the environment variable to flag whether or not to run the live unit test. |
rhiannonlynne
force-pushed
the
tickets/SP-3256
branch
from
July 1, 2026 09:35
2efeb60 to
7f479dd
Compare
Member
Author
|
I think these unit tests are all failing for something other than what I changed -- and I think you might have a fix over on your PR branch? |
rhiannonlynne
force-pushed
the
tickets/SP-3256
branch
from
July 1, 2026 09:57
7f479dd to
a91a8a7
Compare
rhiannonlynne
force-pushed
the
tickets/SP-3256
branch
from
July 1, 2026 09:58
a91a8a7 to
27d8493
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is what you had in mind or not.
I looked at just adding this in a notebook, but the information should go into one of the other HTML markup nicely formatted pieces you had in the output notebook, so that doesn't quite work.
This is about the best I could do for now, but I think you mentioned wanting to rationalize some of the rubin nights vs schedview fetching .. maybe this both indicates that that's a good idea but also illustrates an option?