WIP: GH-20: Create server cache - #131
Draft
etandon-coatue wants to merge 1 commit into
Draft
Conversation
yilinwei
reviewed
Mar 1, 2021
|
|
||
| object Meetup { | ||
|
|
||
| val eventMap: mutable.Map[String, (Int, LocalDateTime)] = |
Collaborator
There was a problem hiding this comment.
Hey! Thanks for opening this PR; Meetup has been down frequently so it would be nice to have some cache for it 😄.
There are a couple of points to consider:
- It would probably be best if we extracted the logic into a separate class and passed it into the
applymethod. This would mean that it's easier to test the cache behavior as an independent unit - In general we avoid mutable state unless there's a good reason to have it (i.e. bottleneck for performance). We can use a Ref with an immutable map to get a primitive concurrent cache.
- In general,
Mapdoesn't provide any guarantees about it's behaviour under concurrent conditions; looking at the implementation of Scala'sMap, I think it would be fine, but it's not great to rely on implementation details.
I think sketching out how the solution might be used first before implementing it is a good idea. Here's a starting point.
trait Cache[F[_], K, V] {
def fetch(key: K, retrieve: K => F[V]): F[V]
}
object Cache {
def apply[F[_]: Sync, K, V](evictionTime: Duration): Cache[F, K, V] = {
???
}
}Thanks for joining the gitter chat and let me know if you encounter any issues.
etandon-coatue
marked this pull request as draft
May 17, 2021 13:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.