Fix RigControl not tracking frequency on initial page load#92
Open
n1zzo wants to merge 1 commit intoluarvique:masterfrom
Open
Fix RigControl not tracking frequency on initial page load#92n1zzo wants to merge 1 commit intoluarvique:masterfrom
n1zzo wants to merge 1 commit intoluarvique:masterfrom
Conversation
rigStart() unconditionally clears fCenter and fOffset after the rigctl
process is started. When wireProperty subscriptions are set up before
rigStart(), the immediate callback from wireProperty("center_freq")
correctly populates fCenter, but rigStart() then overwrites it with None.
This causes setFrequencyOffset() to silently skip all frequency commands
(guarded by `if self.fCenter is not None`) until a profile change
re-fires setCenterFrequency and repopulates fCenter.
Fix by moving rigStart() before the wireProperty subscriptions so that
the clearing happens first (on already-None values) and the property
callbacks then populate fCenter/fOffset with correct values that are
never overwritten.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rigStart() unconditionally clears fCenter and fOffset after the rigctl process is started. When wireProperty subscriptions are set up before rigStart(), the immediate callback from wireProperty("center_freq") correctly populates fCenter, but rigStart() then overwrites it with None.
This causes setFrequencyOffset() to silently skip all frequency commands (guarded by
if self.fCenter is not None) until a profile change re-fires setCenterFrequency and repopulates fCenter.Fix by moving rigStart() before the wireProperty subscriptions so that the clearing happens first (on already-None values) and the property callbacks then populate fCenter/fOffset with correct values that are never overwritten.