added benchmarking methods for cros referencing when needed#9
Merged
Conversation
| return f"https://public.ukp.informatik.tu-darmstadt.de/thakur/BEIR/datasets/{dataset}.zip" | ||
|
|
||
|
|
||
| def _download_and_unzip_dataset(dataset: str, datasets_root: Path) -> Path: |
Collaborator
There was a problem hiding this comment.
What is Path as a type here? If possible pls add a comment
|
|
||
| url = _dataset_url(dataset) | ||
| try: | ||
| from beir import util # type: ignore |
Collaborator
There was a problem hiding this comment.
Is it a kinda lazy loading; want to understand why we have differ the importing here
| def _load_corpus(corpus_path: Path) -> dict[str, str]: | ||
| corpus: dict[str, str] = {} | ||
| with corpus_path.open("r", encoding="utf-8") as fh: | ||
| for line in fh: |
| doc_id = str(row.get("_id", "")).strip() | ||
| if not doc_id: | ||
| continue | ||
| title = str(row.get("title") or "").strip() |
Collaborator
There was a problem hiding this comment.
str(row.get("_id", "")).strip() ; str(row.get("title") or "").strip()
diff between both opt? why we doing or here? what does row.get("title") will return it title wont found
| def _load_queries(queries_path: Path) -> dict[str, str]: | ||
| queries: dict[str, str] = {} | ||
| with queries_path.open("r", encoding="utf-8") as fh: | ||
| for line in fh: |
Collaborator
There was a problem hiding this comment.
^^ fh is not understandable
| with queries_path.open("r", encoding="utf-8") as fh: | ||
| for line in fh: | ||
| row = json.loads(line) | ||
| qid = str(row.get("_id", "")).strip() |
abhiedward001
requested changes
Apr 7, 2026
Collaborator
abhiedward001
left a comment
abhiedward001
left a comment
There was a problem hiding this comment.
Pls ask AI to add comments what all these functions does; cant understand usecase as a new dev
…lain logic of benchmarking
abhiedward001
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added benchmarking methods for anyone to benchmark the repo and get results of how much efficiency search and token reduction is providing