security(sdjwt): apply exp/nbf to the processed payload - #174
Merged
Conversation
RFC 9901 §7.1 step 6 requires the verifier to check those claims on the processed payload if present. The issuer-JWT body was already checked; a selectively disclosed expiry is now too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 9901 §7.1 step 6: check
nbf/expon the processed payload if present. openvc already ran that check on the issuer-JWT body; ifexp/nbfwere selectively disclosed they only appeared after_unpackand were not re-checked.The issuer-JWT body is still checked. The processed payload is now checked as well.
Verified:
bash .claude/skills/ship-issue/scripts/gate.sh.