Skip to content

feat: #258 Loosing registered tree affecting drag and drop between different trees. #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
as666499 wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −2
Open

feat: #258 Loosing registered tree affecting drag and drop between different trees. #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
768ef1a
258: Using the updater function for setting new value for trees to av…
as666499 Jun 8, 2026
a0cff2e
258: updated release notes
as666499 Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions next-release-notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
### Features

### Bug Fixes and Improvements
- Fixes an issue where drag and drop between trees was not working after remount of the target tree(#258)

### Other Changes
-->
7 changes: 5 additions & 2 deletions packages/core/src/controlledEnvironment/useControlledTreeEnvironmentProps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,11 @@ export const useControlledTreeEnvironmentProps = ({
const unregisterTree = useCallback(
treeId => {
onUnregisterTree?.(trees[treeId]);
delete trees[treeId];
setTrees(trees);
setTrees(trees => {
const newTrees = {...trees};
delete newTrees[treeId];
return newTrees;
});
},
[onUnregisterTree, trees]
);
Expand Down