Skip to content

Add tool integration and react bot#1

Open
jialeiY wants to merge 12 commits intolukewu8023:mainfrom
jialeiY:jialei
Open

Add tool integration and react bot#1
jialeiY wants to merge 12 commits intolukewu8023:mainfrom
jialeiY:jialei

Conversation

@jialeiY
Copy link
Copy Markdown

@jialeiY jialeiY commented Nov 20, 2024

No description provided.

Copy link
Copy Markdown
Owner

@lukewu8023 lukewu8023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR Jialei, please find the review comments and make changes

Comment thread core/tools.py
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest this to be moved to a new separate tool folder

Comment thread core/react.py
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this better to be put strategy folder as one of the planning strategies as other two?

Comment thread core/planner.py
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to add new function in the planner, but please do not change the existing plan function because all the existing experiments are broken.

Comment thread prompt/system_context.py
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is SYSTEM_CONTEXT_WITH_TOOLS2 used? if yes, better to give it a more meaningful name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants